-
Notifications
You must be signed in to change notification settings - Fork 8
Switch back to jruby master #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @headius (not sure how well the request review notification works) |
Yup, let's do it. I'll push an updated snapshot for tomorrow's build. |
Oh well nevermind that... the snapshot builds have been going out nightly for 10 already. |
I kicked off a release build to pick up your changes and latest 10 snapshot. |
There's no way to file a bug on this repository. The windows verification uses open-uri and apparently hits a bug in JRuby's fiddle-based win32-based resolv.rb logic. I'm not sure when I'll have a Windows machine handy again for investigating this. We plan to do a separate pass getting Windows stuff working. Perhaps this check should just be disabled for now, so the other builds can get to users.
|
Right, the failed build is https://github.com/ruby/jruby-dev-builder/actions/runs/13828117332/job/38686674321
But then many workflows using jruby-head on Windows might break. It's your decision for this repo, but if you remove the check I expect you to handle all jruby-related issues reported to setup-ruby. Also even if we skip this check here it would break the CI of setup-ruby, and there I don't think it's OK to remove the check (even just for jruby-head), because we would intentionally expose a broken ruby build to users, which I believe nobody wants. |
FYI for ruby-dev-builder we run test-all and test-spec and only publish if both pass. That has saved from publishing numerous broken builds. |
Turns out it was mostly some out of date stdlib. Latest release build was successful. |
I tried setup-ruby with jruby-head in https://github.com/eregon/setup-ruby/actions/runs/13840609310/job/38726887794
i.e. the |
I pushed #722 as an attempt to fix this. Full disclosure: I do not know JS nor any of these libraries. |
Let's try?
See ruby/setup-ruby#721 (comment)