Relax assertion pattern for ruby repo #781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Mar 28, 2025
| @@ -152,7 +152,7 @@ def test_core | |||
|
|
|||
| def test_deprecated_load_create_additions | |||
| pattern = /json_addition_test\.rb.*use JSON\.unsafe_load/ | |||
| if RUBY_ENGINE == 'truffleruby' | |||
| if RUBY_ENGINE == 'truffleruby' || File.basename($0) != 'json_addition_test.rb' | |||
There was a problem hiding this comment.
I don't think that is correct, because even in this repo, when we run bundle exec rake I don't think $0 is json_addtion_test.rb.
Can you show me a failure from ruby/ruby? The PR you pointed seem to have passed fine.
|
I just tested it's |
|
I can just remove that part of the test. |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Mar 31, 2025
Fix: ruby/json#781 Tests are ran a bit differently in ruby/ruby and this assertion breaks. ruby/json@0d4fc669ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_deprecated_load_create_additionsis failing on ruby/ruby repo(ruby/ruby#13004):I'm not sure this fix is good for this test. @byroot Could you review this?