fix for pretty_generate throwing wrong number of arguments error #803
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this error to first appear in 2.11.0 as a breaking change in one of our codebases.
When
State === opts
is false, pretty_generate would eventually call generate with 3 arguments:State.generate(obj, options, nil)
However if
State === opts
, it would originally try to callstate.generate(obj)
with only one argument. However,state
just returns the State class itselfJSON::Ext::Generator::State
and expects 3 arguments.This change aligns the behavior with the regular JSON.generate method to call
opts.generate
instead.