-
Notifications
You must be signed in to change notification settings - Fork 2
A few cleaning up for the mmtk GC module #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruby/ruby@f483bef#diff-db708b4117de648f1041678860fd9c891e3e45773eb1bcde4f4bd83c9558f6ed made changes to the file |
#include "internal/object.h" If I compile the mmtk GC module inside the
But if I copy
|
I fixed this issue on the main branch. |
Remove the unused constant HAS_MOVED_GFIELDSTBL and related methods. In the mmtk/mmtk-ruby repo, we are now able to find the global field (IV) table of a moved object during copying GC without using the HAS_MOVED_GFIELDSTBL bit. We synchronize some of the code, although we haven't implemented moving GC in ruby/mmtk, yet. See: mmtk/mmtk-ruby@13080ac
We also enable `#![warn(unsafe_op_in_unsafe_fn)]` in the whole mmtk_ruby crate.
Ues more idiomatic rust approaches.
This will deny lint and code formatting issues.
All tests passed except |
This pull request includes several commits that clean up the code, including:
HAS_MOVED_GFIELDSTBL
. Themmtk/mmtk-ruby
repo has stopped using that flag a while ago, so we can remove it here, too.mmtk
Rust dependency to the current latest version.cargo clippy
) and formatting issues (cargo fmt --check
).