Merge pull request #170 from rubycdp/linter

Run linter and tests

Author: route

.github/workflows/linter.yml

@@ -2,27 +2,36 @@ name: Linter
 on: [push]
 
 jobs:
-  # linters:
-  #   name: Linters
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - name: Checkout code
-  #       uses: actions/checkout@v2
+  linters:
+    name: Linters
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ 2.7, 3.0 ]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
 
-  #     - name: Setup Ruby
-  #       uses: ruby/setup-ruby@v1
-  #     - name: Ruby gem cache
-  #       uses: actions/cache@v1
-  #       with:
-  #         path: vendor/bundle
-  #         key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
-  #         restore-keys: |
-  #           ${{ runner.os }}-gems-
-  #     - name: Install gems
-  #       run: |
-  #         bundle config path vendor/bundle
-  #         bundle install --jobs 4 --retry 3
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
 
-  #     - name: Run linters
-  #       run: |
-  #         bin/rubocop --parallel
+      - name: Ruby gem cache
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+
+      - name: Install gems
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      - name: Run linters
+        run: |
+          bundle exec rubocop --parallel

.github/workflows/tests.yml

@@ -4,7 +4,6 @@ on:
     branches:
       - master
   pull_request:
-    types: [opened, synchronize, reopened, labeled]
 
 jobs:
   tests:
@@ -39,10 +38,9 @@ jobs:
       - name: Run tests
         run: bundle exec rake
         if: |
-          github.event.pull_request.draft == false ||
-            (github.event.pull_request.draft == true &&
-             contains(github.event.pull_request.labels.*.name, 'master') &&
-             matrix.gemfile == 'ferrum-master')
+          matrix.gemfile != 'ferrum-master' ||
+            (matrix.gemfile == 'ferrum-master' &&
+              contains(github.event.pull_request.labels.*.name, 'master'))
 
       - name: Archive artifacts
         uses: actions/upload-artifact@v2

cuprite.gemspec

@@ -21,7 +21,8 @@ Gem::Specification.new do |s|
     "homepage_uri" => "https://cuprite.rubycdp.com/",
     "bug_tracker_uri" => "https://github.com/rubycdp/cuprite/issues",
     "documentation_uri" => "https://github.com/rubycdp/cuprite/blob/master/README.md",
-    "source_code_uri" => "https://github.com/rubycdp/cuprite"
+    "source_code_uri" => "https://github.com/rubycdp/cuprite",
+    "rubygems_mfa_required" => "true"
   }
 
   s.required_ruby_version = ">= 2.6.0"

lib/capybara/cuprite/driver.rb

@@ -5,6 +5,7 @@
 
 module Capybara
   module Cuprite
+    # rubocop:disable Metrics/ClassLength
     class Driver < Capybara::Driver::Base
       DEFAULT_MAXIMIZE_SCREEN_SIZE = [1366, 768].freeze
       EXTENSION = File.expand_path("javascripts/index.js", __dir__)
@@ -418,5 +419,6 @@ def pdf?(path, options)
           options[:format].to_s == "pdf"
       end
     end
+    # rubocop:enable Metrics/ClassLength
   end
 end

lib/capybara/cuprite/page.rb

@@ -130,6 +130,9 @@ def title
 
       private
 
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
+      # rubocop:disable Style/GuardClause
       def prepare_page
         super
 
@@ -178,6 +181,9 @@ def prepare_page
           command("Page.handleJavaScriptDialog", **options)
         end
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/PerceivedComplexity
+      # rubocop:enable Style/GuardClause
 
       def find_position(node, **options)
         node.find_position(**options)