Skip to content

Conversation

vovanmozg
Copy link

@vovanmozg vovanmozg commented Mar 6, 2024

Fixes #352

@vovanmozg vovanmozg force-pushed the block-reload-config branch from d25a628 to 5db7fc4 Compare March 30, 2024 23:53
@vovanmozg
Copy link
Author

@cjlarose, could you check tests?

@pkuczynski
Copy link
Member

@vovanmozg are you still interested in moving forward with this PR?

@pkuczynski pkuczynski requested a review from Nuzair46 July 15, 2025 11:30
@pkuczynski
Copy link
Member

@Nuzair46 what do you think about this one?

@Nuzair46
Copy link
Member

Nuzair46 commented Jul 15, 2025

@pkuczynski @vovanmozg the failing tests seems to be an issue with Rails 6.1 not loading logger properly.
I was able to fix it by doing this
This can be identified by rescue in the runner code. And I saw logger error.
Before:

`#{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'`

After:

`RUBYOPT="-r logger" #{Rails.root.join("bin", "rails")} runner 'print "\#{Settings.default}|\#{Settings.custom}"'`

This makes ruby to load the logger before anything runs.

@Nuzair46
Copy link
Member

Nuzair46 commented Aug 8, 2025

@vovanmozg Are you able to contribute to this? Or I can help with implementing the rest.

@vovanmozg
Copy link
Author

@vovanmozg Are you able to contribute to this? Or I can help with implementing the rest.

That would be awesome if you could take it over — I’m short on time right now. Really appreciate it!

@Nuzair46
Copy link
Member

This PR will be superseded by #382
@vovanmozg Please check that PR if it satisfies your changes

@vovanmozg
Copy link
Author

This PR will be superseded by #382 @vovanmozg Please check that PR if it satisfies your changes

Thank you!
Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rails integration does not allow multiple YAML files to be specified in the first load
4 participants