Allow specifying the working directory to run the release task in #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
hybras
reviewed
Jan 2, 2025
| - name: Configure trusted publishing credentials | ||
| if: ${{ inputs.setup-trusted-publisher == 'true' }} | ||
| uses: rubygems/configure-rubygems-credentials@v1.0.0 | ||
| working-directory: ${{ inputs.working-directory }} |
erickguan
reviewed
Sep 1, 2025
| git config --global user.name "$(git log -1 --pretty=format:'%an')" | ||
| git remote set-url origin "https://x-access-token:${{ github.token }}@github.com/$GITHUB_REPOSITORY" | ||
| shell: bash | ||
| working-directory: ${{ inputs.working-directory }} |
There was a problem hiding this comment.
Is this useful? The repo folder or sub folders will not affect these commands.
If it's submodule in a repo folder, this will not help. We can remove this.
|
I would love to see a new release with this feature to unblock a gem release. |
|
I hope this pull request gets merged soon so that the working directory becomes configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Signed-off-by: Samuel Giddins segiddins@segiddins.me