Skip to content

web: Don't use .npmrc for detect_chromedriver_version #20041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

web: Don't use .npmrc for detect_chromedriver_version #20041

wants to merge 1 commit into from

Conversation

danielhjacobs
Copy link
Contributor

@danielhjacobs danielhjacobs added A-web Area: Web & Extensions T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Apr 7, 2025
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Apr 7, 2025 •
edited
Loading

I'm not actually sure the config is inherited in the child package.json files though, and if it's not I'm not sure if they might need their own config.

We may need this in more than one package.json: https://github.com/search?q=repo%3Aruffle-rs%2Fruffle%20path%3A%2Fpackage.json&type=code

@torokati44
Copy link
Member

I'm not actually sure the config is inherited in the child package.json files though

How could we find this out?

@danielhjacobs
Copy link
Contributor Author

Looking into it it seems the package.json is not inherited. So the real question is, which package.json files need this environment variable and which do not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian17 adrian17 adrian17 approved these changes

Assignees
No one assigned
Labels
A-web Area: Web & Extensions T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhjacobs @torokati44 @adrian17