Skip to content

Upgrade protobuf to 31.0 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade protobuf to 31.0 #411

wants to merge 2 commits into from

Conversation

daniel-b2c2
Copy link

@daniel-b2c2 daniel-b2c2 commented May 20, 2025 •
edited
Loading

Protobuf 31.0 is available, and it introduces a new Generated annotation. I cannot use rules_grpc_java side-by-side with protobuf without there being an upgrade to 31.0 for both the module and 4.31.0 and the java references.

The following error occurs without this upgrade:

error: could not resolve com.google.protobuf.Generated
@com.google.protobuf.Generated

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file lang-cpp C++ rules specific lang-java Java rules specific lang-objc Objective-C rules specific lang-python Python rules specific lang-buf Buf rules specific labels May 20, 2025
@daniel-b2c2
Copy link
Author

daniel-b2c2 commented May 20, 2025 •
edited
Loading

I see some but not all of the builds are failing. I've no idea.

@daniel-b2c2 daniel-b2c2 mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lang-buf Buf rules specific lang-cpp C++ rules specific lang-java Java rules specific lang-objc Objective-C rules specific lang-python Python rules specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daniel-b2c2