Feature/integration tests config #5
Conversation
|
HI @vpodorozh, thank you for the PR. @mwr and I reviewed this PR, and we have the following change requests:
|
| - name: mariadb:10.4 | ||
| alias: db | ||
| command: ["--innodb-buffer-pool-size=1024M --innodb-log-buffer-size=32M --max_allowed_packet=325058560"] | ||
| - name: docker.elastic.co/elasticsearch/elasticsearch:7.6.2 |
There was a problem hiding this comment.
Research if this can be dynamic
| ELASTICSEARCH_PORT: 9200 | ||
|
|
||
| # mysql config for integration tests | ||
| INSTALL_CONFIG_MYSQL: > |
There was a problem hiding this comment.
Remove this and point the Var to the default Magento path. We have to check in the config.php into VCS then.
There was a problem hiding this comment.
To set the ENVIRONMENT Variables, you can work with sed
There was a problem hiding this comment.
Replace only on lines matching the line pattern:
sed '/line_pattern/s/find/replace/' filename
| - ${PHP_BIN} bin/magento | ||
| - echo "---------- MAGENTO SETUP:INSTALL ----------" | ||
| ## install magento, using 'yes' to answer all interaction questions (yes |) and ignoring all warnings that could occur while installation ( || true) | ||
| - yes | ${PHP_BIN} bin/magento setup:install --db-host=${APP_DB_HOST} --db-name=${APP_DB_NAME} --db-password=${APP_DB_PASS} --db-user=${APP_DB_USER} --search-engine="elasticsearch7" --elasticsearch-host=${ELASTICSEARCH_HOST} --elasticsearch-port=${ELASTICSEARCH_PORT} --admin-email=admin@mwltr.de --admin-firstname=Admin --admin-lastname=Admin --admin-password=admin123 --admin-user=admin --backend-frontname=admin --base-url=http://build.run-as-root.test --currency=EUR --language=en_US --session-save=files --timezone=Europe/Berlin --use-rewrites=1 -vvv || true |
There was a problem hiding this comment.
Please also use redis caching here.
There was a problem hiding this comment.
Please rename the admin-email
|
@vpodorozh do you wanna fix it quickly and we merge it? |
|
we discussed and effort to make it all dynamic doesn't pay off at the end. |
3 participants
Introducing integration tests configs: