feat: integrate anthropic with tool call block #20100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
AstraBert
commented
Oct 23, 2025
| assert "input" in tool_call | ||
| assert "name" in tool_call | ||
|
|
||
| if (tool_call["id"], tool_call["name"]) not in unique_tool_calls: |
There was a problem hiding this comment.
Added this check here to avoid duplicates
AstraBert
commented
Oct 23, 2025
Comment on lines
+430
to
+454
| def update_tool_calls(blocks: list[ContentBlock], tool_call: ToolCallBlock) -> None: | ||
| if len([block for block in blocks if isinstance(block, ToolCallBlock)]) == 0: | ||
| blocks.append(tool_call) | ||
| return | ||
| elif not any( | ||
| block.tool_call_id == tool_call.tool_call_id | ||
| for block in blocks | ||
| if isinstance(block, ToolCallBlock) | ||
| ): | ||
| blocks.append(tool_call) | ||
| return | ||
| elif any( | ||
| block.tool_call_id == tool_call.tool_call_id | ||
| and block.tool_kwargs == tool_call.tool_kwargs | ||
| for block in blocks | ||
| if isinstance(block, ToolCallBlock) | ||
| ): | ||
| return | ||
| else: | ||
| for i, block in enumerate(blocks): | ||
| if isinstance(block, ToolCallBlock): | ||
| if block.tool_call_id == tool_call.tool_call_id: | ||
| blocks[i] = tool_call | ||
| break | ||
| return |
There was a problem hiding this comment.
Added this logic because, since Anthropic streams partial JSON, tool calls with the same ID are streamed, but they might have different tool_kwargs. So:
- We append the tool call if no other tool call is present/there is not tool call with the same ID
- We skip if there is already a tool call with the same ID and arguments
- We update the tool call if there is one with the same ID but it has different arguments
I added a test for this and I also tested end-to-end with the agent script, and now everything goes smooth (no duplicate calls, correct arguments parsing)
logan-markewich
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
ToolCallBlockin Anthropic (tested e2e).