-
Notifications
You must be signed in to change notification settings - Fork 91
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
I don't think our server reads the chat packet correctly. If you set chat to "Off" and then send a message, the chat status is set to "Hide" and packet 32 is sent immediately after the chat packet. This seems to break incoming packets.
I have used an old version of the client to rule out my recent packet changes from being the cause
To Reproduce
Steps to reproduce the behaviour:
- Log into game
- Send a message
- Everything will continue working OK
- Set chat status to "Off"
- Send another message
- All packets afterwards will be read incorrectly by the server
Expected behavior
Both packets (75 and 32) should be read correctly
Additional context
- Both 75 and 32 are read correctly normally, the issue only occurs when 32 is automatically sent
- 32 is sent immediately after 75 if chat was set to "off" https://github.com/runejs/refactored-client-435/blob/c57098f60b17a6773f36cd38078070e3250b9468/src/main/java/org/runejs/client/MovedStatics.java#L1709
- I notice that our
chat.packetuses a length of-3, this is possibly wrong because the client sends a byte indicating the length, so-1might be more suitable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working