Skip to content

Packaging improvements #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amotl opened this issue Apr 3, 2025 · 3 comments
Closed

Packaging improvements #9

amotl opened this issue Apr 3, 2025 · 3 comments

Comments

@amotl
Copy link
Contributor

amotl commented Apr 3, 2025

Dear Rune,

that's an excellent software package, thanks a stack for conceiving it. It works from the start, modulo a few obstacles we observed when installing it.

Would you accept a patch that improves packaging a bit more, by adding a few touches that whip the modules into the mcp_alchemy namespace, and expand pyproject.toml to make it a real package that could also be uploaded to PyPI? 1

With kind regards,
Andreas.

Footnotes

  1. Currently, while installation per pip install ... works, the package will install a module called server into the top-level Python library tree at hand, which is unfortunate, because it can easily yield collisions. This is not a hypothetic thing, because pg-mcp actually does the same, so they can't be installed together into the same Python environment. 2

  2. We hope this specific detail is not a flaw on the recommendations/conventions of MCP itself, how to build an MCP server? If so, relevant documentation should dearly be fixed. If you know anything about it, please let us know. Otherwise, I think it was just an accidental collision that can easily happen when software is still in its infancy. NB: We submitted the same message also to @stuzero per https://github.com/stuzero/pg-mcp/issues/10.

@amotl
Copy link
Contributor Author

amotl commented Apr 3, 2025

We hope this specific detail about using server.py for the module name is not a flaw on the recommendations/conventions of MCP itself, how to build an MCP server? If so, relevant documentation should dearly be fixed. If you know anything about it, please let us know.

We just discovered on the MCP SDK Quickstart documentation that is indeed about starting with a server.py, so now we know where this is coming from ;]. We may raise a relevant suggestion on their issue tracker as we go.

@runekaagaard
Copy link
Owner

runekaagaard commented Apr 3, 2025

Dear amotl

Thx for the PRs! Yeah the project is getting quite the attention, so it makes sense to push it to pypi.

EDIT: Ah I've never actually tested the pip installation instructions, those were from a PR, sry about that. I'll revert the documentation to use the manual git clone method for now, and create a proper package in a unique PYPI namespace early next week.

Thx, a lot for bringing this to my attention!

runekaagaard added a commit that referenced this issue Apr 3, 2025
amotl added a commit to crate-workbench/mcp-alchemy that referenced this issue Apr 3, 2025
@amotl
Copy link
Contributor Author

amotl commented Apr 3, 2025

Hi Rune,

the installation works perfectly well now, and will no longer collide with others that use server.py as the main top-level module as well. Thank you very much for the quick turnaround.

With kind regards,
Andreas.

NB: We are validating your package over here against CrateDB, which is compatible with PostgreSQL, but provides a dedicated dialect. That also spawned a relevant improvement that was needed to make it work. 🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants