[Feature] make the stubs publishable #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation
I'm working on a project with PHPStan enabled at the max level. Every time I generate an API service, PHPStan complains about the generated files, and I've got to fix them manually.
The fix
After digging for a bit, I learned that this package uses CanManipulateFiles trait, which checks for the existence of the stub under
stubs/filamentbefore using the one in the package.So easily enough, I borrowed a couple of lines from filament's repository https://github.com/filamentphp/filament/blob/3.x/packages/panels/src/FilamentServiceProvider.php#L95-L100 to satisfy the need.
Suggestion
I want to open another PR to correctly type the generated files so PHPStan can live with them peacefully if @rupadana doesn't mind it
Screenshots