Make ARCH_WIDTH byte aligned instead of bit aligned#387
Merged
romancardenas merged 1 commit intorust-embedded:masterfrom Jan 13, 2026
Merged
Make ARCH_WIDTH byte aligned instead of bit aligned#387romancardenas merged 1 commit intorust-embedded:masterfrom
romancardenas merged 1 commit intorust-embedded:masterfrom
Conversation
romancardenas
requested changes
Jan 13, 2026
Contributor
romancardenas
left a comment
romancardenas
left a comment
There was a problem hiding this comment.
Thanks!
Please, address the comments. Also. if you modify riscv-rt/Cargo.toml to point to version 0.17.1, I will publish a patch today
kurtjd
force-pushed
the
arch-width-fix
branch
from
dbba20e to
a35a025
Compare
romancardenas
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#385 pointed out the build script is passing
ARCH_WIDTHin bits rather than bytes, so this PR simply divides width by 8 to correctly pass width in bytes. Does indeed seem to help reduce binary size slightly (the one example I tested it on reduced.rodataby 4 bytes).Additionally bumps version to
0.17.1.Resolves #385