riscv-macros: Move entry attribute macro#388
Closed
romancardenas wants to merge 2 commits intoriscv-macrosfrom
Closed
riscv-macros: Move entry attribute macro#388romancardenas wants to merge 2 commits intoriscv-macrosfrom
riscv-macros: Move entry attribute macro#388romancardenas wants to merge 2 commits intoriscv-macrosfrom
Conversation
romancardenas
force-pushed
the
riscv-macros
branch
4 times, most recently
from
79c47a6 to
8049a7f
Compare
Contributor
Author
Contributor
Author
|
closing in favor of #386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #386 . It moves the
entrymacro fromriscv-rt-macrostoriscv-macros.It also serves as an example of how the new macro refactoring allows us to reuse the code for all the attributes, easing the maintenance efforts.