Error on define_opaques entries without any opaques actually referenced

Author: oli-obk

compiler/rustc_ast_lowering/src/item.rs

@@ -1696,7 +1696,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
                 );
                 return None;
             };
-            Some(did)
+            Some((self.lower_span(path.span), did))
         });
         let define_opaques = self.arena.alloc_from_iter(define_opaques);
         self.define_opaques = Some(define_opaques);

compiler/rustc_ast_lowering/src/lib.rs

@@ -99,7 +99,7 @@ struct LoweringContext<'a, 'hir> {
     /// Bodies inside the owner being lowered.
     bodies: Vec<(hir::ItemLocalId, &'hir hir::Body<'hir>)>,
     /// `#[define_opaques]` attributes
-    define_opaques: Option<&'hir [LocalDefId]>,
+    define_opaques: Option<&'hir [(Span, LocalDefId)]>,
     /// Attributes inside the owner being lowered.
     attrs: SortedMap<hir::ItemLocalId, &'hir [hir::Attribute]>,
     /// Collect items that were created by lowering the current owner.

compiler/rustc_hir/src/hir.rs

@@ -1308,7 +1308,7 @@ impl Attribute {
 pub struct AttributeMap<'tcx> {
     pub map: SortedMap<ItemLocalId, &'tcx [Attribute]>,
     /// Preprocessed `#[define_opaques]` attribute.
-    pub define_opaques: Option<&'tcx [LocalDefId]>,
+    pub define_opaques: Option<&'tcx [(Span, LocalDefId)]>,
     // Only present when the crate hash is needed.
     pub opt_hash: Option<Fingerprint>,
 }

compiler/rustc_ty_utils/src/opaque_types.rs

@@ -190,11 +190,14 @@ impl<'tcx> OpaqueTypeCollector<'tcx> {
         let Some(defines) = self.tcx.hir_attrs(hir_id.owner).define_opaques else {
             return;
         };
-        for &define in defines {
+        for &(span, define) in defines {
             trace!(?define);
             let mode = std::mem::replace(&mut self.mode, CollectionMode::Taits);
-            // TODO: check that opaque types were introduced and error otherwise (also add tests)
+            let n = self.opaques.len();
             super::sig_types::walk_types(self.tcx, define, self);
+            if n == self.opaques.len() {
+                self.tcx.dcx().span_err(span, "item does not contain any opaque types");
+            }
             self.mode = mode;
         }
         // Allow using `#[define_opaques]` on assoc methods and type aliases to override the default collection mode in

tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs

@@ -1,8 +1,7 @@
-//@ check-pass
-
 #![feature(type_alias_impl_trait)]
 
 type Thing = ();
 
 #[define_opaques(Thing)]
+//~^ ERROR item does not contain any opaque types
 fn main() {}

tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.stderr

@@ -0,0 +1,8 @@
+error: item does not contain any opaque types
+  --> $DIR/no_opaque.rs:5:18
+   |
+LL | #[define_opaques(Thing)]
+   |                  ^^^^^
+
+error: aborting due to 1 previous error
+