This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Allow variant with no #fail attribute#245
Open
kngwyu wants to merge 3 commits intorust-lang-deprecated:masterfrom
Open
Allow variant with no #fail attribute#245kngwyu wants to merge 3 commits intorust-lang-deprecated:masterfrom
kngwyu wants to merge 3 commits intorust-lang-deprecated:masterfrom
Conversation
If a variant doesn't have fail atrribute, use its' name to display
|
I like the high level feature concept. But is this not what Debug offers already? Should the |
Author
Agreed, I modified to do so. |
Author
|
Now I noticed it's a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a variant doesn't have fail attribute, use its' name to display.
E.g.
I don't think
All variants must have display attributeis user friendly, but feel free to close this PR if you don't like it.