This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Override name in derive#306
Closed
tyranron wants to merge 5 commits intorust-lang-deprecated:masterfrom
Closed
Conversation
Author
|
There are some unrelated formatting changes. They are result of running latest stable |
Author
|
This also dupes fixes from #298 |
Author
|
Closing this as project is deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional
#[fail(name = ...)]attribute intofailure_derive, which allows to specify custom error's name instead of automatically generated. If no attribute is specified then current behavior is preserved.Motivation
It appears to be handy to use
Fail::name()for custom error codes in the code base of the same application. However, doing so disallows derive usage as we need to implementFailmanually. Having ability to overrideFail::name()result in derive simplifies things a lot.Checklist