Skip to content

Remove --all-features #15572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove --all-features #15572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/doc/src/reference/features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,6 @@ enabled:
`package-name/feature-name` syntax can be used to specify features for
specific workspace members.

* `--all-features`: Activates all features of all packages selected on the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple removal is not the right fix here. cargo build and other commands do have that flag.

https://doc.rust-lang.org/nightly/cargo/commands/cargo-build.html#option-cargo-build---all-features

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that, sorry. I'm happy to close this PR or continue to work on it based on any discussions on this or the referenced issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this?

**Note:** Not all flags are available for every Cargo command.
Check each command’s documentation for details.

command-line.

* `--no-default-features`: Does not activate the [`default`
feature](#the-default-feature) of the selected packages.

Expand Down