fix(publish): Switch the 'ctrl-c on wait' line to a help message #15942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-interacts-with-crates.io
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
weihanglo
approved these changes
Sep 9, 2025
epage
force-pushed
the
ctrl-c
branch
3 times, most recently
from
aac83b5 to
6220991
Compare
|
We may want to wait until rust-lang/annotate-snippets-rs#310 |
This was referenced Sep 10, 2025
Unsure if this should be two groups or one group with a message. If its one group, then we'll have a decorative line and then the `help:` will be further indented. I went with what is closer to how we do things today. We can always re-evaluate at a later point.
That is merged and this PR is updated. This should be good to go forward |
weihanglo
approved these changes
Sep 12, 2025
rustbot
removed
the
S-waiting-on-review
Bumped into this today from rustc, so maybe one group matches rustc more? |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 17, 2025
Update cargo submodule 19 commits in 24bb93c388fb8c211a37986539f24a819dc669d3..966f94733bbc94ca51ff9f1e4c49ad250ebbdc50 2025-09-10 23:16:07 +0000 to 2025-09-16 17:24:45 +0000 - fix(frontmatter): Improve error quality (rust-lang/cargo#15972) - fix: wrong variable name in documentation (rust-lang/cargo#15968) - Add "Optimizing Build Performance" section to the Cargo book (rust-lang/cargo#15924) - Remove extra apostrophe in environment-variables.md (rust-lang/cargo#15963) - Clarify warning for using `features` or `default-features` in `patch` (rust-lang/cargo#15953) - fix(frontmatter): Try alternative len code fences (rust-lang/cargo#15952) - feat(cli): Allow completions for third-party subcommand names (rust-lang/cargo#15961) - docs(index): Clarify what we mean by omitting features (rust-lang/cargo#15957) - fix(future): Report all content as a single Report (rust-lang/cargo#15943) - fix(complete): Show local crates/features over other members (rust-lang/cargo#15956) - docs(resolver): Describe the role of the lockfile (rust-lang/cargo#15958) - chore: Skip check-version-bump ci job in forks (rust-lang/cargo#15959) - Eliminate the last three "did you mean" warning phrasings (rust-lang/cargo#15356) - fix(info): Suggest a more universal `cargo tree` command (rust-lang/cargo#15954) - feat(cli): Use ellipses when truncating progress (rust-lang/cargo#15955) - feat(completer): Added completion for `--features` flag (rust-lang/cargo#15309) - fix(publish): Switch the 'ctrl-c on wait' line to a help message (rust-lang/cargo#15942) - docs: move docs building process to contributor guide (rust-lang/cargo#15854) - fix(manifest): Show error source to users (rust-lang/cargo#15939) r? ghost
|
My intention with going with separate groups for now are
|
|
Those points are reasonable. Thanks! Also, regarding the group message, if https://github.com/rust-lang/cargo/pull/15953/files#r2346621001 were one group, the (I don't know if we want to create a ticket tracking these discussions though, maybe?) |
|
Maybe worth commenting on the tracking issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Switches a multi-line note to use annotate_snippet directly in prep for #15917 where these extra lines will be aligned with the first line.
How to test and review this PR?
Notes
Unsure if this should be two groups or one group with a message.
If its one group, then we'll have a decorative line and then the
help:will be further indented.
I went with what is closer to how we do things today. We can always
re-evaluate at a later point.