Skip to content

Conversation

epage
Copy link
Contributor

@epage epage commented Sep 10, 2025

What does this PR try to resolve?

This changes the future-incompat message to be reported in a single Report. The primary motivation is to cleanup the output compared to taking the existing note's and aligning all content with the first line which is what would happen otherwise in #15917.

In preparation for this, the message was cleaned up and made more like what a rustc message might look like.

How to test and review this PR?

@rustbot rustbot added A-future-incompat Area: future incompatible reporting S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@epage
Copy link
Contributor Author

epage commented Sep 10, 2025

We may want to wait until rust-lang/annotate-snippets-rs#310

@epage
Copy link
Contributor Author

epage commented Sep 11, 2025

We may want to wait until rust-lang/annotate-snippets-rs#310

That is merged and this PR is updated. This should be good to go forward

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks nicer

@weihanglo weihanglo added this pull request to the merge queue Sep 12, 2025
Merged via the queue into rust-lang:master with commit 6d221ef Sep 12, 2025
25 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2025
@epage epage deleted the annotate-future branch September 12, 2025 19:02
bors added a commit to rust-lang/rust that referenced this pull request Sep 17, 2025
Update cargo submodule

19 commits in 24bb93c388fb8c211a37986539f24a819dc669d3..966f94733bbc94ca51ff9f1e4c49ad250ebbdc50
2025-09-10 23:16:07 +0000 to 2025-09-16 17:24:45 +0000
- fix(frontmatter): Improve error quality (rust-lang/cargo#15972)
- fix: wrong variable name in documentation (rust-lang/cargo#15968)
- Add "Optimizing Build Performance" section to the Cargo book (rust-lang/cargo#15924)
- Remove extra apostrophe in environment-variables.md (rust-lang/cargo#15963)
- Clarify warning for using `features` or `default-features` in `patch` (rust-lang/cargo#15953)
- fix(frontmatter): Try alternative len code fences (rust-lang/cargo#15952)
- feat(cli): Allow completions for third-party subcommand names (rust-lang/cargo#15961)
- docs(index): Clarify what we mean by omitting features (rust-lang/cargo#15957)
- fix(future): Report all content as a single Report (rust-lang/cargo#15943)
- fix(complete): Show local crates/features over other members  (rust-lang/cargo#15956)
- docs(resolver): Describe the role of the lockfile  (rust-lang/cargo#15958)
- chore: Skip check-version-bump ci job in forks (rust-lang/cargo#15959)
- Eliminate the last three "did you mean" warning phrasings (rust-lang/cargo#15356)
- fix(info): Suggest a more universal `cargo tree` command (rust-lang/cargo#15954)
- feat(cli): Use ellipses when truncating progress (rust-lang/cargo#15955)
- feat(completer): Added completion for `--features` flag (rust-lang/cargo#15309)
- fix(publish): Switch the 'ctrl-c on wait' line to a help message (rust-lang/cargo#15942)
- docs: move docs building process to contributor guide (rust-lang/cargo#15854)
- fix(manifest): Show error source to users (rust-lang/cargo#15939)

r? ghost
@rustbot rustbot added this to the 1.92.0 milestone Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-future-incompat Area: future incompatible reporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants