-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(cargo-util-schemas): Move lockfile schemas #15980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+709
−472
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
598cfab
refactor: move out into_resolve from EncodableResolve
secona 6a97f64
refactor: inline `EncodableSourceId` deserialization
secona ef7814f
refactor: replace `SourceId` in `EncodableSourceId`
secona 982ee85
refactor: make certain fields and methods public
secona 535f773
refactor: define lockfile errors in `cargo-util-schemas`
secona efc42e1
refactor: change imports of `encode`
secona 949e863
refactor: move lockfile schemas to `cargo-util-schemas`
secona 3738481
feat: add lockfile schema generation
secona d51d7f6
chore: bump version
secona 703988f
refactor: rename lockfile schemas scheme
secona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
#[derive(Debug, thiserror::Error)] | ||
#[error(transparent)] | ||
pub struct EncodableSourceIdError(#[from] pub EncodableSourceIdErrorKind); | ||
|
||
#[non_exhaustive] | ||
#[derive(Debug, thiserror::Error)] | ||
pub enum EncodableSourceIdErrorKind { | ||
epage marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
#[error("invalid source `{0}`")] | ||
InvalidSource(String), | ||
|
||
#[error("invalid url `{url}`: {msg}")] | ||
InvalidUrl { url: String, msg: String }, | ||
|
||
#[error("unsupported source protocol: {0}")] | ||
UnsupportedSource(String), | ||
} | ||
|
||
#[derive(Debug, thiserror::Error)] | ||
#[error(transparent)] | ||
pub struct EncodablePackageIdError(#[from] EncodablePackageIdErrorKind); | ||
|
||
impl From<EncodableSourceIdError> for EncodablePackageIdError { | ||
fn from(value: EncodableSourceIdError) -> Self { | ||
EncodablePackageIdErrorKind::Source(value).into() | ||
} | ||
} | ||
|
||
#[non_exhaustive] | ||
#[derive(Debug, thiserror::Error)] | ||
pub enum EncodablePackageIdErrorKind { | ||
#[error("invalid serialied PackageId")] | ||
InvalidSerializedPackageId, | ||
|
||
#[error(transparent)] | ||
Source(#[from] EncodableSourceIdError), | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.