Skip to content

miri-script: also overwrite CARGO_BUILD_BUILD_DIR#4312

Closed
RalfJung wants to merge 1 commit into
rust-lang:masterfrom
RalfJung:cargo-build-dir
Closed

miri-script: also overwrite CARGO_BUILD_BUILD_DIR#4312
RalfJung wants to merge 1 commit into
rust-lang:masterfrom
RalfJung:cargo-build-dir

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented May 7, 2025

Setting just CARGO_TARGET_DIR is no longer enough to control where the build artifacts will go, there's now also CARGO_BUILD_BUILD_DIR. See RalfJung/rustc-build-sysroot#25, rust-lang/cargo#14125.

@RalfJung RalfJung force-pushed the cargo-build-dir branch from 193c89c to 75712c3 Compare May 7, 2025 07:00
@RalfJung RalfJung force-pushed the cargo-build-dir branch from 75712c3 to 2ed9f4e Compare May 7, 2025 08:03
@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented May 7, 2025

Thinking about it, we probably don't need this -- we care about the location of the final binaries, but build.build-dir doesn't affect that, it affects temporary artifacts only (IIUC).

@RalfJung RalfJung closed this May 7, 2025
@RalfJung RalfJung deleted the cargo-build-dir branch May 7, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant