native-lib: allow passing structs as arguments #4466
Conversation
nia-e
force-pushed
the
native-structs
branch
2 times, most recently
from
ca18991 to
4e6a464
Compare
|
|
||
| fn main() { | ||
| let pass_me = PassMe { value: 42, other_value: 1337 }; | ||
| unsafe { pass_struct(pass_me) }; //~ ERROR: Undefined Behavior: passing a non-#[repr(C)] struct over FFI |
There was a problem hiding this comment.
Is this correct? I think it's UB, but maybe if the user intentionally sets #[allow(improper_ctypes)] we might just want to report this as unsupported instead of UB?
nia-e
force-pushed
the
native-structs
branch
2 times, most recently
from
1faf540 to
e9670f0
Compare
|
Think this is ready for review. I split off a bunch of the new code this introduces into a different file to not pollute @rustbot ready |
nia-e
force-pushed
the
native-structs
branch
2 times, most recently
from
7cd63db to
532a735
Compare
|
Seems like there's some trouble here, nvm. @rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
nia-e
force-pushed
the
native-structs
branch
6 times, most recently
from
809f60e to
edfa595
Compare
|
Should be fixed. Also bumped the libffi version since apparently there was a soundness issue that got resolved since the previous version we were on; that wasn't the cause of my test failures, but it's probably smart to include it anyways. There's a couple @rustbot ready |
rustbot
added
S-waiting-on-review
nia-e
force-pushed
the
native-structs
branch
4 times, most recently
from
802f48b to
685a17c
Compare
Blocked on #4456 currently to make rebasing easier when that lands.This allows passing arbitrary structs as arguments to native code; receiving a struct as a return value is not yet implemented. Also includes a couple of tests.I figured the review queue looked a bit too empty :D