feat: add inline_default_generic_parameter assist#21991
Closed
Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Closed
feat: add inline_default_generic_parameter assist#21991Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Amit5601
force-pushed
the
feature/inline-default-generic
branch
2 times, most recently
from
ccacb16 to
33f6fe2
Compare
rustbot
removed
the
S-waiting-on-review
Fixes rust-lang#20391. Adds a new assist to inline a default generic parameter to all of its usages within the current file. Correctly distinguishes between path expressions and path types to avoid invalid syntax generation.
Amit5601
force-pushed
the
feature/inline-default-generic
branch
from
33f6fe2 to
1960656
Compare
rustbot
added
the
S-waiting-on-review
Contributor
|
We have a feature freeze on assists. See https://github.com/rust-lang/rust-analyzer/blob/master/CONTRIBUTING.md. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20391.
Adds a new assist to inline a default generic parameter to all of its usages within the current file. Correctly distinguishes between path expressions and path types to avoid invalid syntax generation.