fix: deduplicate warnings lint in completion list#22005
Closed
barry3406 wants to merge 1 commit intorust-lang:masterfrom
Closed
fix: deduplicate warnings lint in completion list#22005barry3406 wants to merge 1 commit intorust-lang:masterfrom
warnings lint in completion list#22005barry3406 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
The `warnings` lint appeared twice in `#[allow(w` completions because it exists as both a regular lint and a lint group in `rustc -Whelp` output. The codegen concatenated both into DEFAULT_LINTS without checking for overlap. Skip lint groups whose name already appears in the regular lint list when generating DEFAULT_LINTS and RUSTDOC_LINTS. Also regenerated the lints.rs file to remove the current duplicate. Fixes rust-lang#21943
This comment was marked as low quality.
This comment was marked as low quality.
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21943
warningsshows up twice when completing#[allow(wbecause it exists as both a regular lint and a lint group inrustc -Whelpoutput. The codegen inxtask/src/codegen/lints.rswrites both intoDEFAULT_LINTSwithout deduplication.Fix: When iterating lint groups to append to the combined list, skip any group whose name already appeared in the regular lints. Applied the same check for
RUSTDOC_LINTS.Also regenerated
crates/ide-db/src/generated/lints.rsto remove the existing duplicate, and added a regression test that verifieswarningsappears exactly once.AI disclosure: Used Claude as a coding assistant. I reviewed and verified all changes.