feat: Feature a "type annotations needed" diagnostic when an infer var cannot be resolved at the end of inference#22168
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom Apr 24, 2026
Conversation
This is required for reporting unresolved vars, which will come in the next commit.
rustbot
added
the
S-waiting-on-review
…ot be resolved at the end of inference
ChayimFriedman2
force-pushed
the
type-must-be-known-v2
branch
from
371a880 to
a8b5abd
Compare
ChayimFriedman2
changed the title
Veykril
approved these changes
Apr 24, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is case 1 in the description #22144, and completes the cases where this diagnostic should be emitted.
While it mostly works fine and with no false positives (there are false negatives though when we're incorrectly using dummy spans), this diagnostic is not stabilizeable as-is IMO, as the reporting can be a bit unclear. We should polish that a bit (feedback from users will help).