fix: unnested_or_patterns FP on structs with only shorthand field pats
#15343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
ada4a
commented
Jul 25, 2025
| @@ -325,7 +325,11 @@ fn extend_with_struct_pat( | |||
| if idx_1 == idx { | |||
| // In the case of `k`, we merely require identical field names | |||
| // so that we will transform into `ident_k: p1_k | p2_k`. | |||
| let pos = fps2.iter().position(|fp2| eq_id(fp1.ident, fp2.ident)); | |||
| let pos = fps2.iter().position(|fp2| { | |||
| // Avoid `Foo { bar } | Foo { bar }` => `Foo { bar | bar }` | |||
There was a problem hiding this comment.
While this comment is demonstrably correct, I think I'm still missing something -- namely, even before this PR, a pattern like this:
Foo { x, y: 1} | Foo { x, y: 2 }still only got the suggestion to collapse the y part, even though x is technically duplicated as well.
So for some reason, the "deduplication" of x isn't suggested until there aren't any other field patterns to flag (that's also why I called the PR what I did)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unnested_or_patterns]: FP on structs with only shorthand field patternsfixes #15219