-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add suggestion to cast_sign_loss
and cast_possible_wrap
using the cast_{un,}signed()
methods
#15384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RunDevelopment
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
RunDevelopment:issue14150
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lintcheck changes for 4e286bb
This comment will be updated if you push new changes |
You should also include a test with a MSRV of 1.86 to ensure the suggestions are not emitted. |
Jarcho
reviewed
Aug 3, 2025
This comment has been minimized.
This comment has been minimized.
959e7bb
to
4e286bb
Compare
I applied all suggestions from the review. Hope this is good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: Enhancement of lints, like adding more cases or adding help messages
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
cast_sign_loss
,cast_possible_wrap
]: add suggestion usingcast_{un,}signed()
methodsFixes #14150
This PR adds a suggestion to
cast_sign_loss
andcast_possible_wrap
, which fixes reported warnings using thecast_{un,}signed()
methods, as proposed in #14150. Suggestions are only made if MSRV is >=1.87.Also, I'm not 100% sure about the suggestion message yet. I'm open for suggestions.