Skip to content

Commit e0a16fb

Browse files
authored
Merge pull request #902 from apiraino/consistent-target-tier-naming
Consistent tiers target naming
2 parents 35df792 + 6995c30 commit e0a16fb

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

src/compiler/proposals-and-stabilization.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ are suitable for each method of making a proposal - see below):
1818
other team members to raise any concerns.
1919
- Seconding can only be used to approve a MCP.
2020
- FCP
21-
- A final comment period will require sign-off from a majority of the compiler team to approve
22-
a proposal and then a ten day waiting period.
21+
- A Final Comment Period is started by a T-compiler member, it's a tool to get concrete consensus
22+
from the team.
23+
- Requires sign-off from a majority of the compiler team to approve a proposal and then a ten days
24+
waiting period.
2325
- FCPs can be used to approve any form of proposal.
2426

2527
## Proposals
@@ -254,7 +256,7 @@ circumstance.
254256
- **Approve using:** r+ (compiler leads)
255257
- You can `r? compiler_leads` on the PR to roll one of the compiler leads as the reviewer.
256258
- Open a PR with the new target (w/ relevant documentation updates) and document adherence to the
257-
[target tier policy][tier_policy] in the description. New targets must start as tier three
259+
[target tier policy][tier_policy] in the description. New targets must start as tier 3
258260
- New targets should be assigned to the compiler team co-leads to check for any licensing
259261
concerns
260262
- Promoting a target
@@ -264,18 +266,18 @@ circumstance.
264266
in the description
265267
- New targets should be assigned to the compiler team co-leads to ensure that any demands on
266268
the project infrastructure are considered and checked with relevant teams
267-
- Renaming a target or making a breaking change to a tier three target
269+
- Renaming a target or making a breaking change to a tier 3 target
268270
- **Propose using:** PR
269271
- **Approve using:** r+
270272
- Open an PR with the proposed rename and describe the motivation for the change and obtain a r+
271273
from the reviewer.
272-
- Renaming a target or making a breaking change to a tier two target
274+
- Renaming a target or making a breaking change to a tier 2 target
273275
- **Propose using:** MCP
274276
- **Approve using:** FCP
275277
- Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP.
276278
- If approved, the change should be accompanied by a blog post announcing the change with a
277279
notice period of at least one release before the change applies.
278-
- Renaming a target or making a breaking change to a tier one target
280+
- Renaming a target or making a breaking change to a tier 1 target
279281
- **Propose using:** RFC
280282
- **Approve using:** FCP
281283
- Open an RFC describing the motivation for the change and start an FCP to approve, start an FCP.
@@ -286,7 +288,7 @@ circumstance.
286288
- **Approve using:** FCP
287289
- Write an MCP describing why the target should be demoted/removed and once discussion has
288290
concluded, an FCP can be started to approve the demotion/removal.
289-
- If approved and affecting a tier two or one target , the change should be accompanied by a
291+
- If approved and affecting a tier 2 or tier 1 target, the change should be accompanied by a
290292
blog post announcing the change with a notice period of at least one release before the change
291293
applies.
292294
- Changing target baseline (e.g. minimum Darwin or Windows version bump)

src/infra/other-installation-methods.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ might one _not_ want to install using those instructions?
3939

4040
Rust's platform support is defined in [three tiers], which correspond closely
4141
with the installation methods available: in general, the Rust project provides
42-
binary builds for all tier 1 and tier 2 platforms, and they are all installable
43-
via `rustup`. Some tier 2 platforms though have only the standard library
42+
binary builds for all Tier 1 and Tier 2 platforms, and they are all installable
43+
via `rustup`. Some Tier 2 platforms though have only the standard library
4444
available, not the compiler itself; that is, they are cross-compilation targets
4545
only; Rust code can run on those platforms, but they do not run the compiler
4646
itself. Such targets can be installed with the `rustup target add` command.

0 commit comments

Comments
 (0)