From 13342b9dfb1ff03e15822da4fba86074907ebda6 Mon Sep 17 00:00:00 2001 From: apiraino Date: Mon, 16 Jun 2025 11:20:57 +0200 Subject: [PATCH 1/4] Consistent tier target naming --- src/compiler/proposals-and-stabilization.md | 10 +++++----- src/infra/other-installation-methods.md | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index 827845d4..d2a50243 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -254,7 +254,7 @@ circumstance. - **Approve using:** r+ (compiler leads) - You can `r? compiler_leads` on the PR to roll one of the compiler leads as the reviewer. - Open a PR with the new target (w/ relevant documentation updates) and document adherence to the - [target tier policy][tier_policy] in the description. New targets must start as tier three + [target tier policy][tier_policy] in the description. New targets must start as Tier 3 - New targets should be assigned to the compiler team co-leads to check for any licensing concerns - Promoting a target @@ -264,18 +264,18 @@ circumstance. in the description - New targets should be assigned to the compiler team co-leads to ensure that any demands on the project infrastructure are considered and checked with relevant teams -- Renaming a target or making a breaking change to a tier three target +- Renaming a target or making a breaking change to a Tier 3 target - **Propose using:** PR - **Approve using:** r+ - Open an PR with the proposed rename and describe the motivation for the change and obtain a r+ from the reviewer. -- Renaming a target or making a breaking change to a tier two target +- Renaming a target or making a breaking change to a Tier 2 target - **Propose using:** MCP - **Approve using:** FCP - Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP. - If approved, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. -- Renaming a target or making a breaking change to a tier one target +- Renaming a target or making a breaking change to a Tier 1 target - **Propose using:** RFC - **Approve using:** FCP - Open an RFC describing the motivation for the change and start an FCP to approve, start an FCP. @@ -286,7 +286,7 @@ circumstance. - **Approve using:** FCP - Write an MCP describing why the target should be demoted/removed and once discussion has concluded, an FCP can be started to approve the demotion/removal. - - If approved and affecting a tier two or one target , the change should be accompanied by a + - If approved and affecting a Tier 2 or one target, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. - Changing target baseline (e.g. minimum Darwin or Windows version bump) diff --git a/src/infra/other-installation-methods.md b/src/infra/other-installation-methods.md index a7b9c236..d80a6d58 100644 --- a/src/infra/other-installation-methods.md +++ b/src/infra/other-installation-methods.md @@ -39,8 +39,8 @@ might one _not_ want to install using those instructions? Rust's platform support is defined in [three tiers], which correspond closely with the installation methods available: in general, the Rust project provides -binary builds for all tier 1 and tier 2 platforms, and they are all installable -via `rustup`. Some tier 2 platforms though have only the standard library +binary builds for all Tier 1 and Tier 2 platforms, and they are all installable +via `rustup`. Some Tier 2 platforms though have only the standard library available, not the compiler itself; that is, they are cross-compilation targets only; Rust code can run on those platforms, but they do not run the compiler itself. Such targets can be installed with the `rustup target add` command. From 30280e1c1e8b68869ff3fac51e1c2eb00cb4070e Mon Sep 17 00:00:00 2001 From: apiraino Date: Mon, 16 Jun 2025 11:21:16 +0200 Subject: [PATCH 2/4] Clarify FCP --- src/compiler/proposals-and-stabilization.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index d2a50243..b46da91f 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -18,8 +18,10 @@ are suitable for each method of making a proposal - see below): other team members to raise any concerns. - Seconding can only be used to approve a MCP. - FCP - - A final comment period will require sign-off from a majority of the compiler team to approve - a proposal and then a ten day waiting period. + - A Final Comment Period is started by a T-compiler member, it's a tool to get concrete consensus + from the team. + - Requires sign-off from a majority of the compiler team to approve a proposal and then a ten days + waiting period. - FCPs can be used to approve any form of proposal. ## Proposals From 83abef7d3c52865142b13364dd28a77492a9f200 Mon Sep 17 00:00:00 2001 From: apiraino Date: Tue, 17 Jun 2025 12:16:24 +0200 Subject: [PATCH 3/4] Tier -> tier --- src/compiler/proposals-and-stabilization.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index b46da91f..6cbd9625 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -256,7 +256,7 @@ circumstance. - **Approve using:** r+ (compiler leads) - You can `r? compiler_leads` on the PR to roll one of the compiler leads as the reviewer. - Open a PR with the new target (w/ relevant documentation updates) and document adherence to the - [target tier policy][tier_policy] in the description. New targets must start as Tier 3 + [target tier policy][tier_policy] in the description. New targets must start as tier 3 - New targets should be assigned to the compiler team co-leads to check for any licensing concerns - Promoting a target @@ -266,18 +266,18 @@ circumstance. in the description - New targets should be assigned to the compiler team co-leads to ensure that any demands on the project infrastructure are considered and checked with relevant teams -- Renaming a target or making a breaking change to a Tier 3 target +- Renaming a target or making a breaking change to a tier 3 target - **Propose using:** PR - **Approve using:** r+ - Open an PR with the proposed rename and describe the motivation for the change and obtain a r+ from the reviewer. -- Renaming a target or making a breaking change to a Tier 2 target +- Renaming a target or making a breaking change to a tier 2 target - **Propose using:** MCP - **Approve using:** FCP - Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP. - If approved, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. -- Renaming a target or making a breaking change to a Tier 1 target +- Renaming a target or making a breaking change to a tier 1 target - **Propose using:** RFC - **Approve using:** FCP - Open an RFC describing the motivation for the change and start an FCP to approve, start an FCP. @@ -288,7 +288,7 @@ circumstance. - **Approve using:** FCP - Write an MCP describing why the target should be demoted/removed and once discussion has concluded, an FCP can be started to approve the demotion/removal. - - If approved and affecting a Tier 2 or one target, the change should be accompanied by a + - If approved and affecting a tier 2 or one target, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. - Changing target baseline (e.g. minimum Darwin or Windows version bump) From 6995c30f6c5bfe253a4479834f3f0f0279d48ab8 Mon Sep 17 00:00:00 2001 From: Josh Stone Date: Tue, 1 Jul 2025 11:37:45 -0700 Subject: [PATCH 4/4] Update another "tier 1" instance --- src/compiler/proposals-and-stabilization.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index 6cbd9625..0b47c4be 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -288,7 +288,7 @@ circumstance. - **Approve using:** FCP - Write an MCP describing why the target should be demoted/removed and once discussion has concluded, an FCP can be started to approve the demotion/removal. - - If approved and affecting a tier 2 or one target, the change should be accompanied by a + - If approved and affecting a tier 2 or tier 1 target, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. - Changing target baseline (e.g. minimum Darwin or Windows version bump)