[perf] Cache the canonical *instantiation* of param-envs

[compiler-errors]

r? lcnr

[compiler-errors]

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit 10849bc with merge 41eb046…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 41eb046 (41eb046262521d4f258e161c937b19a16cb53f37)

[rust-timer]

Finished benchmarking commit (41eb046): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.9%, -0.1%]	18
Improvements ✅ (secondary)	-4.0%	[-20.1%, -0.1%]	19
All ❌✅ (primary)	-0.5%	[-0.9%, -0.1%]	18

Max RSS (memory usage)

Results (primary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	1

Cycles

Results (primary -1.0%, secondary -7.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.1%, -0.8%]	8
Improvements ✅ (secondary)	-7.8%	[-14.1%, -1.1%]	6
All ❌✅ (primary)	-1.0%	[-1.1%, -0.8%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.415s -> 752.897s (-0.33%)
Artifact size: 372.14 MiB -> 372.01 MiB (-0.04%)

[compiler-errors]

Let's try this again w/o the "highest var in clauses" optimization.

[compiler-errors]

Let's try this but with highest_var_in_clauses not cached.

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit a74d247 with merge 98d94a4…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 98d94a4 (98d94a4710e69795b88dc65dc9526c47d10f54d6, parent: e703dff8fe220b78195c53478e83fb2f68d8499c)

[rust-timer]

Finished benchmarking commit (98d94a4): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.6%]	6
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-0.3%	[-0.6%, -0.1%]	13
Improvements ✅ (secondary)	-2.6%	[-15.9%, -0.1%]	24
All ❌✅ (primary)	-0.0%	[-0.6%, 0.6%]	19

Max RSS (memory usage)

Results (primary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-8.1%	[-8.1%, -8.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.5%	[-8.1%, 1.1%]	2

Cycles

Results (secondary -7.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.1%	[-12.2%, -2.1%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.802s -> 754.047s (-0.10%)
Artifact size: 372.09 MiB -> 372.03 MiB (-0.02%)