add #![rustc_no_implicit_bounds] #142671
Open
add #![rustc_no_implicit_bounds] #142671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
lcnr
reviewed
Jun 18, 2025
lcnr
reviewed
Jun 18, 2025
lcnr
reviewed
Jun 18, 2025
Comment on lines
+2
to
+5
|
|
||
| #![feature(rustc_attrs)] | ||
| #![rustc_no_implicit_bounds] | ||
|
|
There was a problem hiding this comment.
for unsize coercions/trait object coercions test, the attribute makes them a bit confusing/harder to read for me 🤔
so maybe only limit the attribute to tests for the trait solver 🤔
lcnr
reviewed
Jun 18, 2025
tests/ui/traits/next-solver/cycles/coinduction/incompleteness-unstable-result.rs
Show resolved
Hide resolved
lcnr
reviewed
Jun 18, 2025
davidtwco
force-pushed
the
no-default-bounds-attr
branch
from
fabf44b to
d746230
Compare
Sure, go ahead :) |
fbstj
reviewed
Jun 18, 2025
Adds a new `rustc_attrs` attribute that stops rustc from adding any default bounds. Useful for tests where default bounds just add noise and make debugging harder.
After reviewing all tests with `?Sized`, these tests seem like they could probably benefit from `#![rustc_no_implicit_bounds]`. - Skipping most of `tests/ui/unsized` as these seem to want to test `?Sized` - Skipping tests that used `Box<T>` because it's still bound by `T: MetaSized` - Skipping parsing or other tests that cared about `?Sized` syntactically - Skipping tests for `derive(CoercePointee)` because this appears to check that the pointee type is relaxed with `?Sized` explicitly
davidtwco
force-pushed
the
no-default-bounds-attr
branch
from
d746230 to
22a9327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #137944.
Adds a new
rustc_attrsattribute that stops rustc from adding any default bounds. Useful for tests where default bounds just add noise and make debugging harder.After reviewing all tests with
?Sized, these tests seem like they could probably benefit from#![rustc_no_implicit_bounds].tests/ui/unsizedas these seem to want to test?SizedBox<T>because it's still bound byT: MetaSized?Sizedsyntacticallyderive(CoercePointee)because this appears to check that the pointee type is relaxed with?Sizedexplicitlyr? @lcnr