-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Rename mingw-*
CI jobs to pr-*
#143294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename mingw-*
CI jobs to pr-*
#143294
Conversation
This comment has been minimized.
This comment has been minimized.
|
oh, I think having "mingw" in the name might be load-bearing... |
Heh, I was just thinking about this today :) You need to rename the directory with the Dockerfile. |
Doh! That's totally obvious now that you mentioned it 😅 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r? kobzol |
Thanks! @bors r+ rollup=never (I want to make sure that there are no test changes |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6268d0a (parent) -> d612081 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d6120810e56387730b2e86115471354c8084ca4a --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (d612081): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 462.879s -> 461.527s (-0.29%) |
The name
mingw
confuses people because these CI jobs now do much more than just cross-compile to mingw.This is basically a find/replace. I chose the name
pr-
because it's job is to do general PR checks,