remove deprecated from core::ffi::c_str

[hkBst]

No description provided.

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jhpratt]

cc @rust-lang/libs — I'm 99% sure this is acceptable but I'd like to be positive. r=me if that is the case.

[cuviper]

Consolidating the Display impl is a positive change.

I have mixed feelings about dropping any existing Error::description though -- it doesn't hurt anything to leave its current static text in place.

[jhpratt]

Hm, I naïvely assumed that description delegated to the Display impl, but that's not the case. I guess because it returns a &str, which is borrowed rather than owned?

[cuviper]

Right, Display is more powerful for that reason.

[hkBst]

I also assumed description would call into Display, but it is actually:

    #[deprecated(since = "1.42.0", note = "use the Display impl or to_string()")]
    fn description(&self) -> &str {
        "description() is deprecated; use Display"
    }

Deprecation happened 46 stable versions ago, or almost 6 years ago.

[cuviper]

Deprecation happened 46 stable versions ago, or almost 6 years ago.

Sure, but AFAIK we haven't removed any of the existing overrides. If we're going to do that, I think it should be intentional and en masse.

[hkBst]

Sure, but AFAIK we haven't removed any of the existing overrides. If we're going to do that, I think it should be intentional and en masse.

Should I open an issue to gauge opinions on that, or do you want to do it? Or do you have a better idea?

[cuviper]

Sure, if you're interested/motivated to make that happen, go ahead with an issue.