Skip to content

Add Default impls for Pinned Box, Rc, Arc #143717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Default impls for Pinned Box, Rc, Arc #143717

wants to merge 1 commit into from
+65 −4

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Jul 10, 2025 •
edited
Loading

Fixes #143688.

@rustbot label T-libs-api needs-fcp

Also needs a crater run, as the Box impls could theoretically be breaking due to #[fundamental] (though a cursory search suggests this is unlikely to cause issues).

@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 10, 2025
@tgross35 tgross35 added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 10, 2025
@tgross35
Copy link
Contributor

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 10, 2025

⌛ Trying commit 9060b6b with merge 5ef65a4…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 10, 2025
@rust-bors
Auto merge of #143717 - Jules-Bertholet:pin-default, r=<try>
5ef65a4 
Add `Default` impls for `Pin`ned `Box`, `Rc`, `Arc`

Fixes #143688.

`@rustbot` label T-libs-api needs-fcp

Also needs a crater run, as the `Box` impls could theoretically be breaking due to `#[fundamental]` (though a [cursory search](https://github.com/search?q=%2Fimpl%28%3C.*%3E%29%3F+Default+for+Pin%3C%2F+path%3A*.rs&type=code) suggests this is unlikely to cause issues).
@rust-bors
Copy link

rust-bors bot commented Jul 10, 2025

☀️ Try build successful (CI)
Build commit: 5ef65a4 (5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db, parent: 32cd9114712a24010b0583624dc52ac302194128)

@tgross35
Copy link
Contributor

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-143717 created and queued.
🤖 Automatically detected try build 5ef65a4
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-143717 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-143717 is completed!
📊 7 regressed and 5 fixed (662328 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 12, 2025
@Jules-Bertholet
Copy link
Contributor Author

All spurious failures. “prepare-fail (112811)” seems not-great though. Looks like a lot of “no space left on device” errors? If an issue with crater is preventing a large proportion of the crates from being properly tested…

@Skgland
Copy link
Contributor

Skgland commented Jul 12, 2025 •
edited
Loading

All spurious failures. “prepare-fail (112811)” seems not-great though. Looks like a lot of “no space left on device” errors? If an issue with crater is preventing a large proportion of the crates from being properly tested…

Note that the prepare-fail category is a relatively recent change, they used to be categorized as error. Also prepare-fail results are included in the retry-regressed-list.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin<Box<impl Default>> should impl Default
5 participants
@Jules-Bertholet @rustbot @tgross35 @craterbot @Skgland