Constify trait aliases #144291
Constify trait aliases #144291
Conversation
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt HIR ty lowering was modified cc @fmease Changes to the size of AST and/or HIR nodes. cc @nnethercote Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| static_assert_size!(Item, 144); | ||
| static_assert_size!(ItemKind, 80); | ||
| static_assert_size!(Item, 136); | ||
| static_assert_size!(ItemKind, 72); |
|
Clippy changes are approved. |
src/tools/rustfmt/src/visitor.rs
Outdated
There was a problem hiding this comment.
Can we add a simple test case for #![feature(trait_alias, const_trait_impl)] in src/tools/rustfmt/tests/target. Would be nice to make sure rustfmt isn't formatting the code incorrectly.
|
☔ The latest upstream changes (presumably #143897) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
const_trait_alias
branch
2 times, most recently
from
cb809b6 to
7508ac9
Compare
|
☔ The latest upstream changes (presumably #143843) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
const_trait_alias
branch
from
7508ac9 to
5d3eb69
Compare
|
☔ The latest upstream changes (presumably #143884) made this pull request unmergeable. Please resolve the merge conflicts. |
Allow
const trait Foo = Bar + [const] Baz;trait alias declarations. Their rules are the same as with super traits of const traits. So[const] Bazorconst Bazis only required for[const] Fooorconst Foobounds respectively.tracking issue #41517 (part of the general trait alias feature gate, but I can split it out into a separate const trait alias feature gate. I just assumed that const traits would stabilize before trait aliases, and we'd want to stabilize trait aliases together with const trait aliases at the same time)
r? @compiler-errors @fee1-dead