Skip to content

[beta] backports #144800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 2, 2025
Merged

[beta] backports #144800

merged 7 commits into from
Aug 2, 2025

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Aug 1, 2025 •
edited by rustbot
Loading

Backport:

r? @Mark-Simulacrum

@rustbot

This comment was marked as resolved.

Sign in to view
@Urgau Urgau added O-windows Operating system: Windows T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 1, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau added O-SGX Target: SGX O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-hermit Operating System: Hermit O-itron Operating System: ITRON T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 1, 2025
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 7843c04 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Aug 2, 2025

Bumping the p on this beta backport since this close to stable.
@bors p=5 (same prio as rollups)

dswij and others added 4 commits August 2, 2025 07:45
@dswij @Mark-Simulacrum
Move uninlined_format_args to pedantic (rust-lang#15287)
db83b3b 
Fixes rust-lang/rust-clippy#15151

See also
https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/uninlined_format_args.20is.20contentious/

changelog: Move [`uninlined_format_args`] to `pedantic`
@y21 @Mark-Simulacrum
Consider deref'ed argument as non-temporary (rust-lang#15172)
4c75f27 
If there are more than one dereference (there is one corresponding
matched with a borrow in any case), consider that the argument might
point to a place expression, which is the safest choice.

Also, use an appropriate number of dereferences in suggestions involving
arguments using themselves multiple dereferences.

Fixes rust-lang/rust-clippy#15166

changelog: [`swap_with_temporary`]: fix false positive leading to
different semantics being suggested, and use the right number of
dereferences in suggestion

r? y21

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_SUMMARY_START -->

### Summary Notes

-
[beta-nomination](rust-lang/rust-clippy#15172 (comment))
by [samueltardieu](https://github.com/samueltardieu)

*Managed by `@rustbot`—see
[help](https://forge.rust-lang.org/triagebot/note.html) for details*

<!-- TRIAGEBOT_SUMMARY_END -->
<!-- TRIAGEBOT_END -->
@flip1995 @Mark-Simulacrum
Revert "Extend manual_is_variant_and lint to check for boolean map …
c1d016f 
…comparisons (rust-lang#14646)"

This reverts commit 551870d, reversing
changes made to 3927a61.
@flip1995 @Mark-Simulacrum
Revert "return_and_then: only lint returning expressions (rust-lang…
3158607 
…#14783)"

This reverts commit 459364b, reversing
changes made to 62ba996.
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 2, 2025
Closed
@Mark-Simulacrum
Copy link
Member Author

@bors r+

Bundled in #144742

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

📌 Commit 3158607 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

⌛ Testing commit 3158607 with merge 4a18378...

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4a18378 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2025
@bors bors merged commit 4a18378 into rust-lang:beta Aug 2, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.