Make UniformUsize serializable #1646
Merged
+143
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
requested changes
Jul 12, 2025
aleb
force-pushed
the
usize-serializable
branch
2 times, most recently
from
cf0a643 to
4667477
Compare
|
Not sure if the second commit is useful |
aleb
force-pushed
the
usize-serializable
branch
2 times, most recently
from
b185474 to
f0bb4df
Compare
dhardy
approved these changes
Jul 16, 2025
aleb
force-pushed
the
usize-serializable
branch
2 times, most recently
from
b456cd3 to
4177e69
Compare
dhardy
reviewed
Jul 16, 2025
For now the 32-bit implementation is limited to serialization. A (custom) 32-bit deserializer would have to panic when the objects serialized on 64-bit are not usable on 32-bit.
Warnings reported by CI and by `cargo clippy --all-targets --all-features -- -D warnings`
|
Thanks! When do you think will be the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentryMotivation
This allows
WeightedIndex<usize>to be serializable.