examples/print-next.rs
#1647
Merged
examples/print-next.rs
#1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase after #1646. |
dhardy
force-pushed
the
push-twkrrppsqxqz
branch
from
520ceb6 to
dc74661
Compare
newpavlov
approved these changes
Jul 17, 2025
examples/print-next.rs
Outdated
| use rand::{rngs::OsRng, RngCore, TryRngCore}; | ||
|
|
||
| fn main() { | ||
| let mut rng = TryRngCore::unwrap_err(OsRng); |
There was a problem hiding this comment.
ThreadRng could be better fit here.
There was a problem hiding this comment.
We only make two calls to the OS for less total bytes than needed to seed ThreadRng.
There was a problem hiding this comment.
This is an example for unsophisticated users and we should direct them towards ThreadRng, not OsRng.
dhardy
force-pushed
the
push-twkrrppsqxqz
branch
from
dc74661 to
cd47b5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you just want a random number. It seems strange that we didn't already have a handy example to print this:
Also a fix for the new
mismatched_lifetime_syntaxeslint.