Skip to content

CanvasRenderingContext2d.get_image_data argument is float #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CanvasRenderingContext2d.get_image_data argument is float #1920

wants to merge 2 commits into from

Conversation

poccariswet
Copy link

@poccariswet poccariswet commented Dec 18, 2019 •
edited
Loading

issue #1917

according to the spec it should be i32 .

 ImageData getImageData(long sx, long sy, long sw, long sh);

It also fix putImageData

@alexcrichton alexcrichton added breaking-change Tracking breaking changes for the next major version bump (if ever) web-sys Issues related to the `web-sys` crate labels Dec 18, 2019
@alexcrichton
Copy link
Contributor

Thanks for this! This is unfortunately a breaking change though and once that others are probably already relying on, so I've tagged this for the next breaking release of web-sys.

@poccariswet
Copy link
Author

@alexcrichton
Will this request be merged in the next major version release?

@alexcrichton
Copy link
Contributor

Indeed!

@RReverser RReverser mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) web-sys Issues related to the `web-sys` crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poccariswet @alexcrichton