Skip to content

[ROCm] do not use __shfl sync functions #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffdaily
Copy link
Contributor

This avoids a static_assert compile-time failure for HIP.

This avoids a static_assert compile-time failure for HIP.
@jeffdaily
Copy link
Contributor Author

pytest results on an MI200 system. 2801 passed, 1 warning in 11.85s.

/opt/conda/envs/py_3.10/lib/python3.10/site-packages/hypothesis/entry_points.py:23: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
============================================================================================================================ test session starts =============================================================================================================================
platform linux -- Python 3.10.18, pytest-7.3.2, pluggy-1.6.0
rootdir: /var/lib/jenkins/pytorch_scatter
configfile: setup.cfg
plugins: flakefinder-1.1.0, hypothesis-5.35.1, xdist-3.3.1, subtests-0.13.1, xdoctest-1.1.0, cpp-2.3.0, rerunfailures-14.0
collected 2801 items

test_broadcasting.py ..........
test_gather.py ....................................................................................................................................................................................................................................
test_multi_gpu.py ..............................
test_scatter.py ........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
test_segment.py ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
test_zero_tensors.py ....................
composite/test_logsumexp.py ..
composite/test_softmax.py ..
composite/test_std.py .

============================================================================================================================== warnings summary ==============================================================================================================================
test/composite/test_std.py::test_std
  /var/lib/jenkins/pytorch_scatter/test/composite/test_std.py:12: UserWarning: Converting a tensor with requires_grad=True to a scalar may lead to unexpected behavior.
  Consider using tensor.detach() first. (Triggered internally at /var/lib/jenkins/pytorch/torch/csrc/autograd/generated/python_variable_methods.cpp:835.)
    expected = torch.tensor([[std, 0], [0, std]])

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================================================== 2801 passed, 1 warning in 11.85s ======================================================================================================================

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (140d3ad) to head (7b17897).
Report is 18 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   97.23%   98.20%   +0.97%     
==========================================
  Files          10       10              
  Lines         217      223       +6     
==========================================
+ Hits          211      219       +8     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants