Skip to content

Update license headers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Update license headers #3

merged 1 commit into from
Mar 11, 2019

Conversation

rvantonder
Copy link
Owner

Closes #2.

grep -l -r "in the \"hack\" directory of this source tree" * | xargs -L 1 -I % bash -c "sed -i'.original' -e 's/in the \"hack\" directory/in the root directory/g' %

@rvantonder rvantonder merged commit fe7e6fd into master Mar 11, 2019
@rvantonder rvantonder deleted the update-license-headers branch March 11, 2019 22:07
@@ -3,7 +3,7 @@
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've grabbed a very old version of some of these files - if you go look at facebook/hhvm again, you'll find the most recent versions are MIT-licensed

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep--it's worth noting that these versions are consistent with the ones in Pyre, and that's where I took it from. It's worth upstreaming the current files in Hack to Pyre then (and seeing if it breaks anything there). I'm worried that if I just drop in the current Hack files from master that it'll break the interface. Happily accepting PRs; for now it's low priority to check that these are current with Hack. Tracking in #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants