Skip to content

Espressif deprecated dc_as_cmd_phase #256

@ligius-

Description

@ligius-

I had some compilation errors due to dc_as_cmd_phase missing. Reading the documentation, the property has been removed in the latest ESP-IDF:
https://docs.espressif.com/projects/esp-idf/en/v5.4.1/esp32/migration-guides/release-5.x/5.0/peripherals.html#lcd

Not sure how many files are affected but here is the patch that I tested with the board 2432S028Rv3:

diff --git a/src/lvgl_panel_st7789_spi.c b/src/lvgl_panel_st7789_spi.c
index 24ab2cd..3293fdf 100644
--- a/src/lvgl_panel_st7789_spi.c
+++ b/src/lvgl_panel_st7789_spi.c
@@ -62,7 +62,6 @@ lv_display_t *lvgl_lcd_init(uint32_t hor_res, uint32_t ver_res)
         .lcd_cmd_bits = ST7789_SPI_CONFIG_LCD_CMD_BITS,
         .lcd_param_bits = ST7789_SPI_CONFIG_LCD_PARAM_BITS,
         .flags = {
-            .dc_as_cmd_phase = ST7789_SPI_CONFIG_FLAGS_DC_AS_CMD_PHASE,
             .dc_low_on_data = ST7789_SPI_CONFIG_FLAGS_DC_LOW_ON_DATA,
             .octal_mode = ST7789_SPI_CONFIG_FLAGS_OCTAL_MODE,
             .lsb_first = ST7789_SPI_CONFIG_FLAGS_LSB_FIRST}};
diff --git a/src/lvgl_touch_xpt2046_spi.c b/src/lvgl_touch_xpt2046_spi.c
index 9a8ab03..0fcc61b 100644
--- a/src/lvgl_touch_xpt2046_spi.c
+++ b/src/lvgl_touch_xpt2046_spi.c
@@ -3,7 +3,6 @@
 #include <esp32_smartdisplay.h>
 #include <esp_touch_xpt2046.h>
 #include <driver/spi_master.h>
-#include <driver/spi_common_internal.h>

 void xpt2046_lvgl_touch_cb(lv_indev_t *indev, lv_indev_data_t *data)
 {
@@ -56,7 +55,6 @@ lv_indev_t *lvgl_touch_init()
         .lcd_cmd_bits = XPT2046_SPI_CONFIG_LCD_CMD_BITS,
         .lcd_param_bits = XPT2046_SPI_CONFIG_LCD_PARAM_BITS,
         .flags = {
-            .dc_as_cmd_phase = XPT2046_SPI_CONFIG_FLAGS_DC_AS_CMD_PHASE,
             .dc_low_on_data = XPT2046_SPI_CONFIG_FLAGS_DC_LOW_ON_DATA,
             .octal_mode = XPT2046_SPI_CONFIG_FLAGS_OCTAL_MODE,
             .lsb_first = XPT2046_SPI_CONFIG_FLAGS_LSB_FIRST}};

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions