Apply coding standard changes

sabbelasichon · github-actions[bot] · commit 5fcd191c05cb · 2024-02-08T07:16:15.000Z
diff --git a/Classes/Asset/EntrypointLookup.php b/Classes/Asset/EntrypointLookup.php
@@ -114,7 +114,7 @@ private function validateEntryName(string $entryName): void
 
     private function getEntriesData(): array
     {
-        if (null !== $this->entriesData) {
+        if ($this->entriesData !== null) {
             return $this->entriesData;
         }
 
diff --git a/Classes/Asset/EntrypointLookupCollection.php b/Classes/Asset/EntrypointLookupCollection.php
@@ -32,11 +32,11 @@ public function __construct(EntryLookupFactoryInterface $entryLookupFactory, str
 
     public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface
     {
-        if (null === $this->buildEntrypoints) {
+        if ($this->buildEntrypoints === null) {
             $this->buildEntrypoints = $this->entryLookupFactory->getCollection();
         }
-        if (null === $buildName) {
-            if (null === $this->defaultBuildName) {
+        if ($buildName === null) {
+            if ($this->defaultBuildName === null) {
                 throw new UndefinedBuildException(
                     'There is no default build configured: please pass an argument to getEntrypointLookup().'
                 );
diff --git a/Classes/Asset/TagRenderer.php b/Classes/Asset/TagRenderer.php
@@ -78,7 +78,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void
         }
 
         // We do not want to replace null values in $attributes
-        $parameters = array_filter($parameters, static fn ($param) => null !== $param);
+        $parameters = array_filter($parameters, static fn ($param) => $param !== null);
 
         foreach ($files as $index => $file) {
             $this->addAdditionalAbsRefPrefixDirectories($file);
@@ -108,7 +108,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void
 
             $attributes = array_values($attributes);
 
-            $pageRendererMethodName = 'addJS' . (self::POSITION_FOOTER === $scriptTag->getPosition() ? 'Footer' : '');
+            $pageRendererMethodName = 'addJS' . ($scriptTag->getPosition() === self::POSITION_FOOTER ? 'Footer' : '');
 
             if ($scriptTag->isLibrary()) {
                 $pageRendererMethodName .= 'Library';
@@ -119,7 +119,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void
                 $pageRenderer->{$pageRendererMethodName}(...$attributes);
             }
 
-            if (true === $scriptTag->isRegisterFile()) {
+            if ($scriptTag->isRegisterFile() === true) {
                 $this->assetRegistry->registerFile(new File($file, FileType::createScript(), [
                     'integrity' => $integrityHashes[$file] ?? false,
                 ]));
@@ -181,7 +181,7 @@ public function renderWebpackLinkTags(LinkTag $linkTag): void
 
             $pageRenderer->addCssFile(...$attributes);
 
-            if (true === $linkTag->isRegisterFile()) {
+            if ($linkTag->isRegisterFile() === true) {
                 $this->assetRegistry->registerFile(new File($file, FileType::createStyle()));
             }
         }
@@ -205,7 +205,7 @@ private function addAdditionalAbsRefPrefixDirectories(string $file): void
 
             $newDir = basename(dirname($file)) . '/';
 
-            if (false === in_array($newDir, $directories, true)) {
+            if (in_array($newDir, $directories, true) === false) {
                 $GLOBALS['TYPO3_CONF_VARS']['FE']['additionalAbsRefPrefixDirectories'] .= ',' . $newDir;
             }
         }
@@ -217,19 +217,19 @@ private function removeLeadingSlash(string $file, array $parameters): bool
             return true;
         }
 
-        if (null === $this->applicationType) {
+        if ($this->applicationType === null) {
             return false;
         }
 
         if (! $this->applicationType->isFrontend()) {
             return false;
         }
 
-        if ('' === $this->getTypoScriptFrontendController()->absRefPrefix) {
+        if ($this->getTypoScriptFrontendController()->absRefPrefix === '') {
             return false;
         }
 
-        if ('/' === $this->getTypoScriptFrontendController()->absRefPrefix) {
+        if ($this->getTypoScriptFrontendController()->absRefPrefix === '/') {
             return true;
         }
 
@@ -251,15 +251,15 @@ private function removeType(array $parameters): bool
             return false;
         }
 
-        if (null === $this->applicationType) {
+        if ($this->applicationType === null) {
             return false;
         }
 
         if (! $this->applicationType->isFrontend()) {
             return false;
         }
 
-        if (! isset($this->getTypoScriptFrontendController()->config['config']['doctype']) || 'html5' !== $this->getTypoScriptFrontendController()->config['config']['doctype']) {
+        if (! isset($this->getTypoScriptFrontendController()->config['config']['doctype']) || $this->getTypoScriptFrontendController()->config['config']['doctype'] !== 'html5') {
             return false;
         }
 
diff --git a/Classes/Form/FormDataProvider/RichtextEncoreConfiguration.php b/Classes/Form/FormDataProvider/RichtextEncoreConfiguration.php
@@ -31,11 +31,11 @@ public function __construct(EntrypointLookupCollectionInterface $entrypointLooku
     public function addData(array $result): array
     {
         foreach ($result['processedTca']['columns'] as $fieldName => $fieldConfig) {
-            if (! isset($fieldConfig['config']['type']) || 'text' !== $fieldConfig['config']['type']) {
+            if (! isset($fieldConfig['config']['type']) || $fieldConfig['config']['type'] !== 'text') {
                 continue;
             }
 
-            if (! isset($fieldConfig['config']['enableRichtext']) || true !== (bool) $fieldConfig['config']['enableRichtext']) {
+            if (! isset($fieldConfig['config']['enableRichtext']) || (bool) $fieldConfig['config']['enableRichtext'] !== true) {
                 continue;
             }
 
@@ -72,7 +72,7 @@ private function getContentCss(string $contentsCss): array
         $buildAndEntryName = GeneralUtility::trimExplode(':', $cssFile, true, 2);
         $buildName = EntrypointLookupInterface::DEFAULT_BUILD;
 
-        if (2 === count($buildAndEntryName)) {
+        if (count($buildAndEntryName) === 2) {
             [$buildName, $entryName] = $buildAndEntryName;
         } else {
             $entryName = $buildAndEntryName[0];
diff --git a/Classes/Integration/AssetRegistry.php b/Classes/Integration/AssetRegistry.php
@@ -54,7 +54,7 @@ public function getRegisteredFiles(): array
 
     public function getDefaultAttributes(): array
     {
-        if (0 === count($this->defaultAttributes)) {
+        if (count($this->defaultAttributes) === 0) {
             $this->defaultAttributes['crossorigin'] = $this->settingsService->getStringByPath('preload.crossorigin');
         }
         return $this->defaultAttributes;
diff --git a/Classes/Integration/EntryLookupFactory.php b/Classes/Integration/EntryLookupFactory.php
@@ -42,7 +42,7 @@ public function __construct(
      */
     public function getCollection(): array
     {
-        if (null !== self::$collection) {
+        if (self::$collection !== null) {
             return self::$collection;
         }
 
diff --git a/Classes/Integration/Filesystem.php b/Classes/Integration/Filesystem.php
@@ -20,7 +20,7 @@ public function get(string $pathToFile): string
     {
         $data = GeneralUtility::getUrl($pathToFile);
 
-        if (false === $data) {
+        if ($data === false) {
             throw new UnexpectedValueException(sprintf('Data could not be read from file %s', $pathToFile));
         }
 
@@ -47,7 +47,7 @@ public function createHash(string $entrypointJsonPath): string
     {
         $md5HashOfFile = md5_file($entrypointJsonPath);
 
-        if (false === $md5HashOfFile) {
+        if ($md5HashOfFile === false) {
             $message = sprintf('File "%s" could not be md5Hashed', $entrypointJsonPath);
             throw new UnexpectedValueException($message);
         }
diff --git a/Classes/Integration/JsonDecoder.php b/Classes/Integration/JsonDecoder.php
@@ -17,7 +17,7 @@ public function decode(string $json): array
     {
         // In PHP 7.3 you can use JSON_THROW_ON_ERROR constant
         $array = json_decode($json, true);
-        if (JSON_ERROR_NONE !== json_last_error()) {
+        if (json_last_error() !== JSON_ERROR_NONE) {
             throw new JsonDecodeException(json_last_error_msg());
         }
 
diff --git a/Classes/Integration/PackageFactory.php b/Classes/Integration/PackageFactory.php
@@ -30,7 +30,7 @@ public function __construct(SettingsServiceInterface $settingsService, Filesyste
 
     public function getPackage(string $package): JsonPackage
     {
-        $manifestJsonPath = EntrypointLookupInterface::DEFAULT_BUILD === $package ? 'manifestJsonPath' : sprintf(
+        $manifestJsonPath = $package === EntrypointLookupInterface::DEFAULT_BUILD ? 'manifestJsonPath' : sprintf(
             'packages.%s.manifestJsonPath',
             $package
         );
diff --git a/Classes/Integration/PageRendererHooks.php b/Classes/Integration/PageRendererHooks.php
@@ -46,7 +46,7 @@ public function renderPreProcess(array $params, PageRenderer $pageRenderer): voi
             }
 
             // Is the include type 'jsLibs' and should be treated as a library
-            $isLibrary = TagRendererInterface::POSITION_JS_LIBRARY === $includeType;
+            $isLibrary = $includeType === TagRendererInterface::POSITION_JS_LIBRARY;
 
             foreach ($params[$includeType] as $key => $jsFile) {
                 if (! $this->isEncoreEntryName($jsFile['file'])) {
@@ -56,7 +56,7 @@ public function renderPreProcess(array $params, PageRenderer $pageRenderer): voi
                 $buildAndEntryName = $this->createBuildAndEntryName($jsFile['file']);
                 $buildName = EntrypointLookupInterface::DEFAULT_BUILD;
 
-                if (2 === count($buildAndEntryName)) {
+                if (count($buildAndEntryName) === 2) {
                     [$buildName, $entryName] = $buildAndEntryName;
                 } else {
                     $entryName = $buildAndEntryName[0];
@@ -85,7 +85,7 @@ public function renderPreProcess(array $params, PageRenderer $pageRenderer): voi
                 $buildAndEntryName = $this->createBuildAndEntryName($cssFile['file']);
                 $buildName = EntrypointLookupInterface::DEFAULT_BUILD;
 
-                if (2 === count($buildAndEntryName)) {
+                if (count($buildAndEntryName) === 2) {
                     [$buildName, $entryName] = $buildAndEntryName;
                 } else {
                     $entryName = $buildAndEntryName[0];
diff --git a/Classes/Integration/SettingsService.php b/Classes/Integration/SettingsService.php
@@ -27,7 +27,7 @@ public function __construct(ConfigurationManagerInterface $configurationManager)
 
     public function getSettings(): array
     {
-        if (null === $this->settings) {
+        if ($this->settings === null) {
             $this->settings = $this->configurationManager->getConfiguration(
                 ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS,
                 'Typo3Encore'
diff --git a/Classes/Integration/TypoScriptFrontendControllerHooks.php b/Classes/Integration/TypoScriptFrontendControllerHooks.php
@@ -34,7 +34,7 @@ public function __construct(AssetRegistryInterface $assetRegistry, SettingsServi
     public function contentPostProcAll(array $params, TypoScriptFrontendController $tsfe): void
     {
         $registeredFiles = $this->assetRegistry->getRegisteredFiles();
-        if ([] === $registeredFiles) {
+        if ($registeredFiles === []) {
             return;
         }
 
diff --git a/Classes/Middleware/AssetsMiddleware.php b/Classes/Middleware/AssetsMiddleware.php
@@ -58,12 +58,12 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         $registeredFiles = $this->collectRegisteredFiles();
 
-        if ([] === $registeredFiles) {
+        if ($registeredFiles === []) {
             return $response;
         }
 
         $linkProvider = $request->getAttribute('_links');
-        if (null === $linkProvider) {
+        if ($linkProvider === null) {
             $request = $request->withAttribute('_links', new GenericLinkProvider());
         }
 
@@ -74,7 +74,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         foreach ($registeredFiles as $rel => $relFiles) {
             // You can disable or enable one of the resource hints via typoscript simply by adding something like that preload.enable = 1, dns-prefetch.enable = 1
-            if (false === $this->getBooleanConfigByPath(sprintf('%s.enable', $rel))) {
+            if ($this->getBooleanConfigByPath(sprintf('%s.enable', $rel)) === false) {
                 continue;
             }
 
@@ -99,7 +99,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         /** @var GenericLinkProvider $linkProvider */
         $linkProvider = $request->getAttribute('_links');
 
-        if ([] !== $linkProvider->getLinks()) {
+        if ($linkProvider->getLinks() !== []) {
             /** @var LinkInterface[]|Traversable $links */
             $links = $linkProvider->getLinks();
             $serializedLinks = (new HttpHeaderSerializer())->serialize($links);
@@ -116,7 +116,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
     private function canAddCrossOriginAttribute(bool $crossOrigin, string $rel): bool
     {
-        return false !== $crossOrigin && '' !== (string) $crossOrigin && in_array(
+        return $crossOrigin !== false && (string) $crossOrigin !== '' && in_array(
             $rel,
             self::$crossOriginAllowed,
             true
@@ -141,7 +141,7 @@ private function collectDefaultAttributes(): array
 
     private function getBooleanConfigByPath(string $path): bool
     {
-        if ([] !== $this->settingsService->getSettings()) {
+        if ($this->settingsService->getSettings() !== []) {
             return $this->settingsService->getBooleanByPath($path);
         }
 
diff --git a/Classes/ViewHelpers/Stimulus/AbstractViewHelper.php b/Classes/ViewHelpers/Stimulus/AbstractViewHelper.php
@@ -39,7 +39,7 @@ public function renderStimulusController(
                 E_USER_DEPRECATED
             );
 
-            if ([] !== $controllerValues || [] !== $controllerClasses) {
+            if ($controllerValues !== [] || $controllerClasses !== []) {
                 throw new \InvalidArgumentException(
                     'You cannot pass an array to the first and second/third argument of stimulus_controller(): check the documentation.'
                 );
@@ -79,7 +79,7 @@ public function renderStimulusAction(
                 E_USER_DEPRECATED
             );
 
-            if (null !== $actionName || null !== $eventName || [] !== $parameters) {
+            if ($actionName !== null || $eventName !== null || $parameters !== []) {
                 throw new \InvalidArgumentException(
                     'You cannot pass a string to the second or third argument nor an array to the fourth argument while passing an array to the first argument of stimulus_action(): check the documentation.'
                 );
@@ -156,7 +156,7 @@ public function renderStimulusTarget($controllerName, string $targetNames = null
                 E_USER_DEPRECATED
             );
 
-            if (null !== $targetNames) {
+            if ($targetNames !== null) {
                 throw new \InvalidArgumentException(
                     'You cannot pass a string to the second argument while passing an array to the first argument of stimulus_target(): check the documentation.'
                 );
diff --git a/Classes/ViewHelpers/Stimulus/Dto/StimulusActionsDto.php b/Classes/ViewHelpers/Stimulus/Dto/StimulusActionsDto.php
@@ -19,7 +19,7 @@ final class StimulusActionsDto extends AbstractStimulusDto
 
     public function __toString(): string
     {
-        if (0 === \count($this->actions)) {
+        if (\count($this->actions) === 0) {
             return '';
         }
 
@@ -46,7 +46,7 @@ public function addAction(
         $controllerName = $this->getFormattedControllerName($controllerName);
         $action = $controllerName . '#' . $this->escapeAsHtmlAttr($actionName);
 
-        if (null !== $eventName) {
+        if ($eventName !== null) {
             $action = $eventName . '->' . $action;
         }
 
diff --git a/Classes/ViewHelpers/Stimulus/Dto/StimulusControllersDto.php b/Classes/ViewHelpers/Stimulus/Dto/StimulusControllersDto.php
@@ -21,7 +21,7 @@ class StimulusControllersDto extends AbstractStimulusDto
 
     public function __toString(): string
     {
-        if (0 === \count($this->controllers)) {
+        if (\count($this->controllers) === 0) {
             return '';
         }
 
@@ -46,7 +46,7 @@ public function addController(
         $this->controllers[] = $controllerName;
 
         foreach ($controllerValues as $key => $value) {
-            if (null === $value) {
+            if ($value === null) {
                 continue;
             }
 
@@ -65,7 +65,7 @@ public function addController(
 
     public function toArray(): array
     {
-        if (0 === \count($this->controllers)) {
+        if (\count($this->controllers) === 0) {
             return [];
         }
 
diff --git a/Classes/ViewHelpers/Stimulus/Dto/StimulusTargetsDto.php b/Classes/ViewHelpers/Stimulus/Dto/StimulusTargetsDto.php
@@ -17,7 +17,7 @@ final class StimulusTargetsDto extends AbstractStimulusDto
 
     public function __toString(): string
     {
-        if (0 === \count($this->targets)) {
+        if (\count($this->targets) === 0) {
             return '';
         }
 
diff --git a/Classes/ViewHelpers/SvgViewHelper.php b/Classes/ViewHelpers/SvgViewHelper.php
@@ -134,12 +134,12 @@ public function render(): string
             $icon = $iconNodeList
                 ->item(0);
 
-            if (null !== $icon) {
+            if ($icon !== null) {
                 if ($icon instanceof DOMElement && $icon->hasAttribute('viewBox')) {
                     $this->tag->addAttribute('viewBox', $icon->getAttribute('viewBox'));
                 }
                 foreach ($icon->childNodes as $node) {
-                    if (null === $node->ownerDocument) {
+                    if ($node->ownerDocument === null) {
                         continue;
                     }
                     $content[] = $node->ownerDocument->saveXML($node);
diff --git a/Tests/Unit/Form/FormDataProvider/RichtextEncoreConfigurationTest.php b/Tests/Unit/Form/FormDataProvider/RichtextEncoreConfigurationTest.php
diff --git a/Tests/Unit/Integration/JsonDecoderTest.php b/Tests/Unit/Integration/JsonDecoderTest.php

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ private function validateEntryName(string $entryName): void`
`114`	`114`
`115`	`115`	`private function getEntriesData(): array`
`116`	`116`	`{`
`117`		`- if (null !== $this->entriesData) {`
	`117`	`+ if ($this->entriesData !== null) {`
`118`	`118`	`return $this->entriesData;`
`119`	`119`	`}`
`120`	`120`
Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,11 @@ public function __construct(EntryLookupFactoryInterface $entryLookupFactory, str`
`32`	`32`
`33`	`33`	`public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface`
`34`	`34`	`{`
`35`		`- if (null === $this->buildEntrypoints) {`
	`35`	`+ if ($this->buildEntrypoints === null) {`
`36`	`36`	`$this->buildEntrypoints = $this->entryLookupFactory->getCollection();`
`37`	`37`	`}`
`38`		`- if (null === $buildName) {`
`39`		`- if (null === $this->defaultBuildName) {`
	`38`	`+ if ($buildName === null) {`
	`39`	`+ if ($this->defaultBuildName === null) {`
`40`	`40`	`throw new UndefinedBuildException(`
`41`	`41`	`'There is no default build configured: please pass an argument to getEntrypointLookup().'`
`42`	`42`	`);`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`// We do not want to replace null values in $attributes`
`81`		`- $parameters = array_filter($parameters, static fn ($param) => null !== $param);`
	`81`	`+ $parameters = array_filter($parameters, static fn ($param) => $param !== null);`
`82`	`82`
`83`	`83`	`foreach ($files as $index => $file) {`
`84`	`84`	`$this->addAdditionalAbsRefPrefixDirectories($file);`
`@@ -108,7 +108,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void`
`108`	`108`
`109`	`109`	`$attributes = array_values($attributes);`
`110`	`110`
`111`		`- $pageRendererMethodName = 'addJS' . (self::POSITION_FOOTER === $scriptTag->getPosition() ? 'Footer' : '');`
	`111`	`+ $pageRendererMethodName = 'addJS' . ($scriptTag->getPosition() === self::POSITION_FOOTER ? 'Footer' : '');`
`112`	`112`
`113`	`113`	`if ($scriptTag->isLibrary()) {`
`114`	`114`	`$pageRendererMethodName .= 'Library';`
`@@ -119,7 +119,7 @@ public function renderWebpackScriptTags(ScriptTag $scriptTag): void`
`119`	`119`	`$pageRenderer->{$pageRendererMethodName}(...$attributes);`
`120`	`120`	`}`
`121`	`121`
`122`		`- if (true === $scriptTag->isRegisterFile()) {`
	`122`	`+ if ($scriptTag->isRegisterFile() === true) {`
`123`	`123`	`$this->assetRegistry->registerFile(new File($file, FileType::createScript(), [`
`124`	`124`	`'integrity' => $integrityHashes[$file] ?? false,`
`125`	`125`	`]));`
`@@ -181,7 +181,7 @@ public function renderWebpackLinkTags(LinkTag $linkTag): void`
`181`	`181`
`182`	`182`	`$pageRenderer->addCssFile(...$attributes);`
`183`	`183`
`184`		`- if (true === $linkTag->isRegisterFile()) {`
	`184`	`+ if ($linkTag->isRegisterFile() === true) {`
`185`	`185`	`$this->assetRegistry->registerFile(new File($file, FileType::createStyle()));`
`186`	`186`	`}`
`187`	`187`	`}`
`@@ -205,7 +205,7 @@ private function addAdditionalAbsRefPrefixDirectories(string $file): void`
`205`	`205`
`206`	`206`	`$newDir = basename(dirname($file)) . '/';`
`207`	`207`
`208`		`- if (false === in_array($newDir, $directories, true)) {`
	`208`	`+ if (in_array($newDir, $directories, true) === false) {`
`209`	`209`	`$GLOBALS['TYPO3_CONF_VARS']['FE']['additionalAbsRefPrefixDirectories'] .= ',' . $newDir;`
`210`	`210`	`}`
`211`	`211`	`}`
`@@ -217,19 +217,19 @@ private function removeLeadingSlash(string $file, array $parameters): bool`
`217`	`217`	`return true;`
`218`	`218`	`}`
`219`	`219`
`220`		`- if (null === $this->applicationType) {`
	`220`	`+ if ($this->applicationType === null) {`
`221`	`221`	`return false;`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`if (! $this->applicationType->isFrontend()) {`
`225`	`225`	`return false;`
`226`	`226`	`}`
`227`	`227`
`228`		`- if ('' === $this->getTypoScriptFrontendController()->absRefPrefix) {`
	`228`	`+ if ($this->getTypoScriptFrontendController()->absRefPrefix === '') {`
`229`	`229`	`return false;`
`230`	`230`	`}`
`231`	`231`
`232`		`- if ('/' === $this->getTypoScriptFrontendController()->absRefPrefix) {`
	`232`	`+ if ($this->getTypoScriptFrontendController()->absRefPrefix === '/') {`
`233`	`233`	`return true;`
`234`	`234`	`}`
`235`	`235`
`@@ -251,15 +251,15 @@ private function removeType(array $parameters): bool`
`251`	`251`	`return false;`
`252`	`252`	`}`
`253`	`253`
`254`		`- if (null === $this->applicationType) {`
	`254`	`+ if ($this->applicationType === null) {`
`255`	`255`	`return false;`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`if (! $this->applicationType->isFrontend()) {`
`259`	`259`	`return false;`
`260`	`260`	`}`
`261`	`261`
`262`		`- if (! isset($this->getTypoScriptFrontendController()->config['config']['doctype']) \|\| 'html5' !== $this->getTypoScriptFrontendController()->config['config']['doctype']) {`
	`262`	`+ if (! isset($this->getTypoScriptFrontendController()->config['config']['doctype']) \|\| $this->getTypoScriptFrontendController()->config['config']['doctype'] !== 'html5') {`
`263`	`263`	`return false;`
`264`	`264`	`}`
`265`	`265`
Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ public function __construct(EntrypointLookupCollectionInterface $entrypointLooku`
`31`	`31`	`public function addData(array $result): array`
`32`	`32`	`{`
`33`	`33`	`foreach ($result['processedTca']['columns'] as $fieldName => $fieldConfig) {`
`34`		`- if (! isset($fieldConfig['config']['type']) \|\| 'text' !== $fieldConfig['config']['type']) {`
	`34`	`+ if (! isset($fieldConfig['config']['type']) \|\| $fieldConfig['config']['type'] !== 'text') {`
`35`	`35`	`continue;`
`36`	`36`	`}`
`37`	`37`
`38`		`- if (! isset($fieldConfig['config']['enableRichtext']) \|\| true !== (bool) $fieldConfig['config']['enableRichtext']) {`
	`38`	`+ if (! isset($fieldConfig['config']['enableRichtext']) \|\| (bool) $fieldConfig['config']['enableRichtext'] !== true) {`
`39`	`39`	`continue;`
`40`	`40`	`}`
`41`	`41`
`@@ -72,7 +72,7 @@ private function getContentCss(string $contentsCss): array`
`72`	`72`	`$buildAndEntryName = GeneralUtility::trimExplode(':', $cssFile, true, 2);`
`73`	`73`	`$buildName = EntrypointLookupInterface::DEFAULT_BUILD;`
`74`	`74`
`75`		`- if (2 === count($buildAndEntryName)) {`
	`75`	`+ if (count($buildAndEntryName) === 2) {`
`76`	`76`	`[$buildName, $entryName] = $buildAndEntryName;`
`77`	`77`	`} else {`
`78`	`78`	`$entryName = $buildAndEntryName[0];`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function getRegisteredFiles(): array`
`54`	`54`
`55`	`55`	`public function getDefaultAttributes(): array`
`56`	`56`	`{`
`57`		`- if (0 === count($this->defaultAttributes)) {`
	`57`	`+ if (count($this->defaultAttributes) === 0) {`
`58`	`58`	`$this->defaultAttributes['crossorigin'] = $this->settingsService->getStringByPath('preload.crossorigin');`
`59`	`59`	`}`
`60`	`60`	`return $this->defaultAttributes;`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct(`
`42`	`42`	`*/`
`43`	`43`	`public function getCollection(): array`
`44`	`44`	`{`
`45`		`- if (null !== self::$collection) {`
	`45`	`+ if (self::$collection !== null) {`
`46`	`46`	`return self::$collection;`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public function get(string $pathToFile): string`
`20`	`20`	`{`
`21`	`21`	`$data = GeneralUtility::getUrl($pathToFile);`
`22`	`22`
`23`		`- if (false === $data) {`
	`23`	`+ if ($data === false) {`
`24`	`24`	`throw new UnexpectedValueException(sprintf('Data could not be read from file %s', $pathToFile));`
`25`	`25`	`}`
`26`	`26`
`@@ -47,7 +47,7 @@ public function createHash(string $entrypointJsonPath): string`
`47`	`47`	`{`
`48`	`48`	`$md5HashOfFile = md5_file($entrypointJsonPath);`
`49`	`49`
`50`		`- if (false === $md5HashOfFile) {`
	`50`	`+ if ($md5HashOfFile === false) {`
`51`	`51`	`$message = sprintf('File "%s" could not be md5Hashed', $entrypointJsonPath);`
`52`	`52`	`throw new UnexpectedValueException($message);`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public function decode(string $json): array`
`17`	`17`	`{`
`18`	`18`	`// In PHP 7.3 you can use JSON_THROW_ON_ERROR constant`
`19`	`19`	`$array = json_decode($json, true);`
`20`		`- if (JSON_ERROR_NONE !== json_last_error()) {`
	`20`	`+ if (json_last_error() !== JSON_ERROR_NONE) {`
`21`	`21`	`throw new JsonDecodeException(json_last_error_msg());`
`22`	`22`	`}`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function __construct(SettingsServiceInterface $settingsService, Filesyste`
`30`	`30`
`31`	`31`	`public function getPackage(string $package): JsonPackage`
`32`	`32`	`{`
`33`		`- $manifestJsonPath = EntrypointLookupInterface::DEFAULT_BUILD === $package ? 'manifestJsonPath' : sprintf(`
	`33`	`+ $manifestJsonPath = $package === EntrypointLookupInterface::DEFAULT_BUILD ? 'manifestJsonPath' : sprintf(`
`34`	`34`	`'packages.%s.manifestJsonPath',`
`35`	`35`	`$package`
`36`	`36`	`);`