-
Notifications
You must be signed in to change notification settings - Fork 0
Separate declare and get params #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean, and it should be compatible with existing code?!
|
||
private: | ||
void update_interal_params(Params updated_params) { | ||
std::lock_guard<std::mutex> lock(mutex_); | ||
params_ = updated_params; | ||
} | ||
|
||
Params get_internal_params_copy() const{ | ||
std::lock_guard<std::mutex> lock(mutex_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we need the mutex here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as we are accessing the the params_
variable which could be modified by the callback at the same time
...ameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich I ran the tests after compiling with this library, in principle they are passing on the |
No description provided.