C++11 range-based for loop 対応 (CProfile) #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Oct 8, 2025
| for(const auto& iter : m_ProfileData) { | ||
| MYTRACE( L"\n■strSectionName=%ls", iter.strSectionName.c_str() ); | ||
| for(const auto& mapiter : iter.mapEntries) { | ||
| MYTRACE( L"\"%ls\" = \"%ls\"\n", mapiter.first.c_str(), mapiter.second.c_str() ); |
Contributor
There was a problem hiding this comment.
引っかかる余地があるのはここだけと思いますが、C++11対応をうたっているので問題なしと思います。
（「mapのkey-value列挙にはC++17の構造化束縛を使おう」の指摘はあり得る。）
beru
reviewed
Nov 9, 2025
| vecLine.push_back( LTEXT("") ); | ||
| } | ||
| for(auto iter = m_ProfileData.cbegin(); iter != m_ProfileData.cend(); iter++ ) { | ||
| for(const auto& iter : m_ProfileData) { |
Contributor
There was a problem hiding this comment.
変更後はこの変数は iterator ではないと思うのでちょっと変数名に違和感があります。まぁ細かい事を言い出すときりが無いですが。
Contributor
There was a problem hiding this comment.
マジメにネーミングすると seciton ですね。
プロファイル
┗セクション1
┣キー1 ＝ 値1
┣キー2 ＝ 値2
┗キー3 ＝ 値3
という構造。セクションは配列（vector）、セクション内のkey-valueはマップ（map）なので
線形イテレーターの iter 、マップイテレーターの mapIter という変数名にしたものと思われます。
gorogoro123
deleted the
feature/apply_cpp11_range_based_for_loop_CProfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
C++11 から range-based for loop が使用できるので、簡潔に記述できる。
仕様・動作説明
PR の影響範囲
影響なし。
テスト内容
デバッガの引数に "-NOWIN" を追加
タスクトレイから、サクラエディタの全終了を選択
関連 issue, PR
#1733
#416
参考資料
https://cpprefjp.github.io/lang/cpp11/range_based_for.html