wcsncpy 置換 (CEditWnd::ChangeFileNameNotify) #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
reviewed
Oct 20, 2025
|
|
||
| CRecentEditNode cRecentEditNode; | ||
| nIndex = cRecentEditNode.FindItemByHwnd( GetHwnd() ); | ||
| int nIndex = cRecentEditNode.FindItemByHwnd( GetHwnd() ); |
Contributor
There was a problem hiding this comment.
指摘じゃないですが、 const auto で宣言すべきと思います。
int でも構わないけど const は付けるべき。
berryzplus
reviewed
Oct 20, 2025
| int size = _countof( p->m_szTabCaption ) - 1; | ||
| wcsncpy( p->m_szTabCaption, pszTabCaption, size ); | ||
| p->m_szTabCaption[ size ] = L'\0'; | ||
| wcsncpy_s( p->m_szTabCaption, _countof(p->m_szTabCaption), pszTabCaption, _TRUNCATE ); |
Contributor
There was a problem hiding this comment.
指摘じゃないです。 m_szTabCaptionが生配列なのを対策したいですが、StaticStringに移行しようとするとここを含めてあちこち変えないといけないので手が付けられない状態です。
| size = _countof2( p->m_szFilePath ) - 1; | ||
| wcsncpy( p->m_szFilePath, pszFilePath, size ); | ||
| p->m_szFilePath[ size ] = L'\0'; | ||
| wcsncpy_s( p->m_szFilePath, _countof2(p->m_szFilePath), pszFilePath, _TRUNCATE ); |
Contributor
There was a problem hiding this comment.
指摘じゃないです。m_szFilePathはCFilePathなので、以下のように書けます。
Suggested change
| wcsncpy_s( p->m_szFilePath, _countof2(p->m_szFilePath), pszFilePath, _TRUNCATE ); | |
| p->m_szFilePath = pszFilePath; |
| if( nullptr == pszTabCaption ) pszTabCaption = L""; //ガード | ||
| if( nullptr == pszFilePath ) pszFilePath = L""; //ガード 2006.01.28 ryoji | ||
|
|
||
| CRecentEditNode cRecentEditNode; |
Contributor
There was a problem hiding this comment.
指摘じゃないです。編集ノードの操作に責任を持つクラスがたくさんあるので、将来的にCRecentEditNodeクラスを削除すべきと思っています。
Contributor
|
変更内容には関係しない事ですが、タイトルが更新されない場合にも |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
CEditWnd::ChangeFileNameNotify() で wcsncpy() 呼び出し、null 文字を設定している。
仕様・動作説明
wcsncpy() を wcsncpy_s() に置換します。
PR の影響範囲
テスト内容
CEditWnd::ChangeFileNameNotify() 呼び出し時に、m_szTabCaption、m_szTabCaption より大きいサイズの文字列を設定して確認する。
関連 issue, PR
参考資料
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strncpy-s-strncpy-s-l-wcsncpy-s-wcsncpy-s-l-mbsncpy-s-mbsncpy-s-l