Skip to content

Commit 549d981

Browse files
authored
Merge pull request #224 from salesforce/grpc-refresh
gRPC 1.54.0 and protobuf 3.22.2
2 parents fb98270 + 2c70df4 commit 549d981

File tree

5 files changed

+21
-22
lines changed

5 files changed

+21
-22
lines changed

contrib/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<mavenBaseUrl>https://oss.sonatype.org/content/repositories</mavenBaseUrl>
6060

6161
<!-- Dependency Versions -->
62-
<grpc.version>1.51.0</grpc.version>
63-
<protoc.version>3.21.9</protoc.version> <!-- Same version as grpc-proto -->
62+
<grpc.version>1.54.0</grpc.version>
63+
<protoc.version>3.22.2</protoc.version> <!-- Same version as grpc-proto -->
6464
<slf4j.version>2.0.5</slf4j.version>
6565
<gson.version>2.10</gson.version> <!-- Same version as grpc-proto -->
6666
<mustache-java.version>0.9.10</mustache-java.version>

demos/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<contrib.version>0.8.2-SNAPSHOT</contrib.version>
6060
<jprotoc.version>0.8.1</jprotoc.version>
6161

62-
<grpc.version>1.51.0</grpc.version>
63-
<protoc.version>3.21.9</protoc.version> <!-- Same version as grpc-proto -->
62+
<grpc.version>1.54.0</grpc.version>
63+
<protoc.version>3.22.2</protoc.version> <!-- Same version as grpc-proto -->
6464
<slf4j.version>2.0.5</slf4j.version>
6565
<gson.version>2.10</gson.version> <!-- Same version as grpc-proto -->
6666
<mustache-java.version>0.9.4</mustache-java.version>

jprotoc/jprotoc/src/main/java/com/salesforce/jprotoc/ProtoTypeMap.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,13 @@ public static ProtoTypeMap of(@Nonnull Collection<DescriptorProtos.FileDescripto
4444
final DescriptorProtos.FileOptions fileOptions = fileDescriptor.getOptions();
4545

4646
final String protoPackage = fileDescriptor.hasPackage() ? "." + fileDescriptor.getPackage() : "";
47-
final String javaPackage = Strings.emptyToNull(
48-
fileOptions.hasJavaPackage() ?
49-
fileOptions.getJavaPackage() :
50-
fileDescriptor.getPackage());
51-
final String enclosingClassName =
52-
fileOptions.getJavaMultipleFiles() ?
53-
null :
54-
getJavaOuterClassname(fileDescriptor, fileOptions);
55-
47+
final String javaPackage = Strings.emptyToNull(fileOptions.hasJavaPackage() ? fileOptions.getJavaPackage() : fileDescriptor.getPackage());
48+
final String enclosingClassName = fileOptions.getJavaMultipleFiles() ? null : getJavaOuterClassname(fileDescriptor);
5649

5750
// Identify top-level enums
58-
fileDescriptor.getEnumTypeList().forEach(
59-
e -> types.put(
60-
protoPackage + "." + e.getName(),
61-
DOT_JOINER.join(javaPackage, enclosingClassName, e.getName())));
51+
fileDescriptor.getEnumTypeList().forEach(e -> types.put(
52+
protoPackage + "." + e.getName(),
53+
DOT_JOINER.join(javaPackage, enclosingClassName, e.getName())));
6254

6355
// Identify top-level messages, and nested types
6456
fileDescriptor.getMessageTypeList().forEach(
@@ -102,9 +94,15 @@ public String toJavaTypeName(@Nonnull String protoTypeName) {
10294
return types.get(protoTypeName);
10395
}
10496

105-
private static String getJavaOuterClassname(
106-
DescriptorProtos.FileDescriptorProto fileDescriptor,
107-
DescriptorProtos.FileOptions fileOptions) {
97+
/**
98+
* Computes the Java outer class name for a given FileDescriptorProto, for use when multiple classes are generated
99+
* in the same outer class.
100+
* @param fileDescriptor
101+
* @return
102+
*/
103+
public static String getJavaOuterClassname(DescriptorProtos.FileDescriptorProto fileDescriptor) {
104+
Preconditions.checkNotNull(fileDescriptor, "fileDescriptor");
105+
DescriptorProtos.FileOptions fileOptions = fileDescriptor.getOptions();
108106

109107
if (fileOptions.hasJavaOuterClassname()) {
110108
return fileOptions.getJavaOuterClassname();

jprotoc/jprotoc/src/main/java/com/salesforce/jprotoc/ProtocPlugin.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ public static void debug(
160160
String name = Files.getNameWithoutExtension(file.getName()) +
161161
"-" +
162162
file.getInsertionPoint() +
163+
"." +
163164
Files.getFileExtension(file.getName());
164165
outFile = new File(name);
165166
}

jprotoc/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@
5858
<mavenBaseUrl>https://oss.sonatype.org/content/repositories</mavenBaseUrl>
5959

6060
<!-- Dependency Versions -->
61-
<protoc.version>3.21.9</protoc.version>
61+
<protoc.version>3.22.2</protoc.version>
6262
<gson.version>2.10</gson.version>
6363
<mustache-java.version>0.9.10</mustache-java.version>
6464

6565
<!-- Test Dependency Versions -->
6666
<contrib.version>0.8.1</contrib.version>
67-
<grpc.version>1.51.0</grpc.version>
67+
<grpc.version>1.54.0</grpc.version>
6868
<junit.version>4.13.1</junit.version>
6969
<assertj.version>3.23.1</assertj.version>
7070
<commons-lang.version>2.6</commons-lang.version>

0 commit comments

Comments
 (0)